[PATCH] staging: fbtft: Remove unnecessary parentheses

Antonio Riccio posted 1 patch 1 year ago
drivers/staging/fbtft/fb_ili9320.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] staging: fbtft: Remove unnecessary parentheses
Posted by Antonio Riccio 1 year ago
Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: Unnecessary parentheses around 'devcode != 0x0000'
CHECK: Unnecessary parentheses around 'devcode != 0x9320'

Signed-off-by: Antonio Riccio <linux@ariccio.me>
---
 drivers/staging/fbtft/fb_ili9320.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c
index 050fc2367c12..9f97cfa34b81 100644
--- a/drivers/staging/fbtft/fb_ili9320.c
+++ b/drivers/staging/fbtft/fb_ili9320.c
@@ -35,7 +35,7 @@ static int init_display(struct fbtft_par *par)
 	par->fbtftops.reset(par);
 
 	devcode = read_devicecode(par);
-	if ((devcode != 0x0000) && (devcode != 0x9320))
+	if (devcode != 0x0000 && devcode != 0x9320)
 		dev_warn(par->info->device,
 			 "Unrecognized Device code: 0x%04X (expected 0x9320)\n",
 			devcode);
-- 
2.43.0
Re: [PATCH] staging: fbtft: Remove unnecessary parentheses
Posted by Greg KH 1 year ago
On Tue, Dec 10, 2024 at 02:18:48PM +0000, Antonio Riccio wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> CHECK: Unnecessary parentheses around 'devcode != 0x0000'
> CHECK: Unnecessary parentheses around 'devcode != 0x9320'
> 
> Signed-off-by: Antonio Riccio <linux@ariccio.me>
> ---
>  drivers/staging/fbtft/fb_ili9320.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Checkpatch is wrong here, sorry.  Please see the archives for the
details as to why I don't take changes like this.

sorry,

greg k-h