[v2] IB/hfi1: Avoid -Wflex-array-member-not-at-end warning

[PATCH v2][next] IB/hfi1: Avoid -Wflex-array-member-not-at-end warning

Posted by Gustavo A. R. Silva 1 week, 2 days ago

-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.

Remove unused flex-array member `class_data` from
`struct opa_mad_notice_attr`.

Fix the following warning:

drivers/infiniband/hw/hfi1/mad.c:23:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
Changes in v2:
 - Remove unused flexible array. (Jason)

v1:
 - Link: https://lore.kernel.org/linux-hardening/Z-WgwsCYIXaBxnvs@kspp/

 drivers/infiniband/hw/hfi1/mad.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/mad.h b/drivers/infiniband/hw/hfi1/mad.h
index b6e3141253c4..d6dde762921a 100644
--- a/drivers/infiniband/hw/hfi1/mad.h
+++ b/drivers/infiniband/hw/hfi1/mad.h
@@ -124,7 +124,6 @@ struct opa_mad_notice_attr {
 		} __packed ntc_2048;
 
 	};
-	u8	class_data[];
 };
 
 #define IB_VLARB_LOWPRI_0_31    1
-- 
2.43.0

Re: [PATCH v2][next] IB/hfi1: Avoid -Wflex-array-member-not-at-end warning

Posted by Jason Gunthorpe 3 days ago

On Tue, Apr 01, 2025 at 11:29:06AM -0600, Gustavo A. R. Silva wrote:
> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are
> getting ready to enable it, globally.
> 
> Remove unused flex-array member `class_data` from
> `struct opa_mad_notice_attr`.
> 
> Fix the following warning:
> 
> drivers/infiniband/hw/hfi1/mad.c:23:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> Changes in v2:
>  - Remove unused flexible array. (Jason)
> 
> v1:
>  - Link: https://lore.kernel.org/linux-hardening/Z-WgwsCYIXaBxnvs@kspp/
> 
>  drivers/infiniband/hw/hfi1/mad.h | 1 -
>  1 file changed, 1 deletion(-)

Applied to for-next, thanks

Jason