[PATCH][next] platform/x86: Avoid -Wflex-array-member-not-at-end warning

Gustavo A. R. Silva posted 1 patch 10 months, 2 weeks ago
drivers/platform/x86/sony-laptop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH][next] platform/x86: Avoid -Wflex-array-member-not-at-end warning
Posted by Gustavo A. R. Silva 10 months, 2 weeks ago
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.

Move the conflicting declaration to the end of the structure. Notice
that `struct acpi_resource_irq` is a flexible structure --a structure
that contains a flexible-array member.

Fix the following warning:

drivers/platform/x86/sony-laptop.c:3330:41: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/platform/x86/sony-laptop.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 3197aaa69da7..9cd6d4a10ddb 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -3327,8 +3327,10 @@ struct sony_pic_ioport {
 };
 
 struct sony_pic_irq {
-	struct acpi_resource_irq	irq;
 	struct list_head		list;
+
+	/* Must be last --ends in a flexible-array member. */
+	struct acpi_resource_irq	irq;
 };
 
 struct sonypi_eventtypes {
-- 
2.43.0
Re: [PATCH][next] platform/x86: Avoid -Wflex-array-member-not-at-end warning
Posted by Ilpo Järvinen 10 months ago
On Thu, 27 Mar 2025 13:22:44 -0600, Gustavo A. R. Silva wrote:

> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are
> getting ready to enable it, globally.
> 
> Move the conflicting declaration to the end of the structure. Notice
> that `struct acpi_resource_irq` is a flexible structure --a structure
> that contains a flexible-array member.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: Avoid -Wflex-array-member-not-at-end warning
      commit: a62372b6c9284ed42c68a0d8b3148f2dde61b4e4

--
 i.