ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line

[PATCH] ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line

Posted by Dmitry Torokhov 1 year, 6 months ago

at86rf230 driver starts with having reset line high, and then drives it
low and then high again, and even calls it "rstn" internally, therefore
it needs to be annotated as "active low" in the DTS.

This will make difference when at86rf230 driver will be converted to
gpiod API that respects declared line polarity.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index de79dcfd32e6..f892977da9e4 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -259,7 +259,7 @@ atzb-rf-233@1 {
 		xtal-trim = /bits/ 8 <0x06>;
 
 		sleep-gpio = <&gpio0 24 GPIO_ACTIVE_HIGH>;
-		reset-gpio = <&gpio6 10 GPIO_ACTIVE_HIGH>;
+		reset-gpio = <&gpio6 10 GPIO_ACTIVE_LOW>;
 
 		fsl,spi-cs-sck-delay = <180>;
 		fsl,spi-sck-cs-delay = <250>;
-- 
2.38.0.rc1.362.ged0d419d3c-goog


-- 
Dmitry

Re: [PATCH] ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line

Posted by Shawn Guo 1 year, 6 months ago

On Fri, Sep 30, 2022 at 11:23:03AM -0700, Dmitry Torokhov wrote:
> at86rf230 driver starts with having reset line high, and then drives it
> low and then high again, and even calls it "rstn" internally, therefore
> it needs to be annotated as "active low" in the DTS.
> 
> This will make difference when at86rf230 driver will be converted to
> gpiod API that respects declared line polarity.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Applied, thanks!