[PATCH][next] scsi: hptiop: Replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command

Gustavo A. R. Silva posted 1 patch 3 years, 6 months ago
drivers/scsi/hptiop.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH][next] scsi: hptiop: Replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command
Posted by Gustavo A. R. Silva 3 years, 6 months ago
One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element array with flexible-array
member in struct hpt_iop_request_ioctl_command.

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/205
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/scsi/hptiop.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hptiop.h b/drivers/scsi/hptiop.h
index ef2f2aca598c..394ef6aa469e 100644
--- a/drivers/scsi/hptiop.h
+++ b/drivers/scsi/hptiop.h
@@ -237,7 +237,7 @@ struct hpt_iop_request_ioctl_command {
 	__le32 inbuf_size;
 	__le32 outbuf_size;
 	__le32 bytes_returned;
-	u8     buf[1];
+	u8     buf[];
 	/* out data should be put at buf[(inbuf_size+3)&~3] */
 };
 
-- 
2.34.1
Re: [PATCH][next] scsi: hptiop: Replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command
Posted by Martin K. Petersen 3 years, 6 months ago
Gustavo,

> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct hpt_iop_request_ioctl_command.

Applied to 6.1/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH][next] scsi: hptiop: Replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command
Posted by Kees Cook 3 years, 6 months ago
On Thu, Sep 22, 2022 at 12:00:46PM -0500, Gustavo A. R. Silva wrote:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct hpt_iop_request_ioctl_command.

I see no binary differences with the patch, so that's good! :)

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook