[PATCH] selftests/binderfs: Improve message to provide more info

Karthik Alapati posted 1 patch 4 years ago
tools/testing/selftests/filesystems/binderfs/binderfs_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] selftests/binderfs: Improve message to provide more info
Posted by Karthik Alapati 4 years ago
Currently the binderfs test says what failure it encountered
without saying why it may occurred when it fails to mount
binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
running kernel.

Signed-off-by: Karthik Alapati <mail@karthek.com>
---
 tools/testing/selftests/filesystems/binderfs/binderfs_test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
index 0315955ff0f4..bc1c407651fc 100644
--- a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
+++ b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
@@ -412,7 +412,8 @@ TEST(binderfs_stress)
 
 		ret = mount(NULL, binderfs_mntpt, "binder", 0, 0);
 		ASSERT_EQ(ret, 0) {
-			TH_LOG("%s - Failed to mount binderfs", strerror(errno));
+			TH_LOG("%s - Failed to mount binderfs, check if CONFIG_ANDROID_BINDERFS is enabled in the running kernel",
+				strerror(errno));
 		}
 
 		for (int i = 0; i < ARRAY_SIZE(fds); i++) {
-- 
2.35.2
Re: [PATCH] selftests/binderfs: Improve message to provide more info
Posted by Christian Brauner 4 years ago
On Sat, Apr 23, 2022 at 11:14:34AM +0530, Karthik Alapati wrote:
> Currently the binderfs test says what failure it encountered
> without saying why it may occurred when it fails to mount
> binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
> running kernel.
> 
> Signed-off-by: Karthik Alapati <mail@karthek.com>
> ---

Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Re: [PATCH] selftests/binderfs: Improve message to provide more info
Posted by Shuah Khan 4 years ago
On 4/25/22 3:49 AM, Christian Brauner wrote:
> On Sat, Apr 23, 2022 at 11:14:34AM +0530, Karthik Alapati wrote:
>> Currently the binderfs test says what failure it encountered
>> without saying why it may occurred when it fails to mount
>> binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
>> running kernel.
>>
>> Signed-off-by: Karthik Alapati <mail@karthek.com>
>> ---
> 
> Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> 

Thank you both - I will apply this for next to be included in
Linux 5.19-rc1

thanks,
-- Shuah