hwrng: mpfs - Enable COMPILE_TEST

Posted by Herbert Xu 4 years ago

The dependency on HW_RANDOM is redundant so this patch removes it.
As this driver seems to cross-compile just fine we could also enable
COMPILE_TEST.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 18aa97974b8b..dad084c0ecee 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -387,7 +387,7 @@ config HW_RANDOM_PIC32
 
 config HW_RANDOM_POLARFIRE_SOC
 	tristate "Microchip PolarFire SoC Random Number Generator support"
-	depends on HW_RANDOM && POLARFIRE_SOC_SYS_CTRL
+	depends on POLARFIRE_SOC_SYS_CTRL || COMPILE_TEST
 	help
 	  This driver provides kernel-side support for the Random Number
 	  Generator hardware found on PolarFire SoC (MPFS).
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: hwrng: mpfs - Enable COMPILE_TEST

Posted by Conor.Dooley@microchip.com 4 years ago

On 15/04/2022 08:37, Herbert Xu wrote:
> The dependency on HW_RANDOM is redundant so this patch removes it.
> As this driver seems to cross-compile just fine we could also enable
> COMPILE_TEST.

Sorry about that. Compile test makes sense to me too.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com

Thanks for applying my patch :)
Conor

> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 18aa97974b8b..dad084c0ecee 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -387,7 +387,7 @@ config HW_RANDOM_PIC32
>   
>   config HW_RANDOM_POLARFIRE_SOC
>   	tristate "Microchip PolarFire SoC Random Number Generator support"
> -	depends on HW_RANDOM && POLARFIRE_SOC_SYS_CTRL
> +	depends on POLARFIRE_SOC_SYS_CTRL || COMPILE_TEST
>   	help
>   	  This driver provides kernel-side support for the Random Number
>   	  Generator hardware found on PolarFire SoC (MPFS).

Re: hwrng: mpfs - Enable COMPILE_TEST

Posted by Conor.Dooley@microchip.com 4 years ago

On 15/04/2022 10:18, Conor.Dooley@microchip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 15/04/2022 08:37, Herbert Xu wrote:
>> The dependency on HW_RANDOM is redundant so this patch removes it.
>> As this driver seems to cross-compile just fine we could also enable
>> COMPILE_TEST.
> 
> Sorry about that. Compile test makes sense to me too.
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com
woops, missing a >.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> 
> Thanks for applying my patch :)
> Conor
> 
>>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>>
>> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
>> index 18aa97974b8b..dad084c0ecee 100644
>> --- a/drivers/char/hw_random/Kconfig
>> +++ b/drivers/char/hw_random/Kconfig
>> @@ -387,7 +387,7 @@ config HW_RANDOM_PIC32
>>
>>    config HW_RANDOM_POLARFIRE_SOC
>>        tristate "Microchip PolarFire SoC Random Number Generator support"
>> -     depends on HW_RANDOM && POLARFIRE_SOC_SYS_CTRL
>> +     depends on POLARFIRE_SOC_SYS_CTRL || COMPILE_TEST
>>        help
>>          This driver provides kernel-side support for the Random Number
>>          Generator hardware found on PolarFire SoC (MPFS).
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv