[RFC PATCH linux-next] mm/shmem: vma_needs_copy can be static

kernel test robot posted 1 patch 4 years ago
mm/memory.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[RFC PATCH linux-next] mm/shmem: vma_needs_copy can be static
Posted by kernel test robot 4 years ago
mm/memory.c:1238:1: warning: symbol 'vma_needs_copy' was not declared. Should it be static?

Fixes: 729c63ce2bbd ("mm/shmem: handle uffd-wp during fork()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 mm/memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index a426c46dd6f68..92cca76bcd3ee 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1234,7 +1234,7 @@ copy_p4d_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma,
  * false when we can speed up fork() by allowing lazy page faults later until
  * when the child accesses the memory range.
  */
-bool
+static bool
 vma_needs_copy(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma)
 {
 	/*
Re: [RFC PATCH linux-next] mm/shmem: vma_needs_copy can be static
Posted by Peter Xu 4 years ago
On Thu, Apr 14, 2022 at 12:02:16AM +0800, kernel test robot wrote:
> mm/memory.c:1238:1: warning: symbol 'vma_needs_copy' was not declared. Should it be static?
> 
> Fixes: 729c63ce2bbd ("mm/shmem: handle uffd-wp during fork()")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu