ANDROID: sched/fair: __pcpu_scope_eenv_cache can be static

[RFC PATCH jsarha] ANDROID: sched/fair: __pcpu_scope_eenv_cache can be static

kernel test robot posted 1 patch 4 years ago

Download mbox

kernel/sched/fair.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[RFC PATCH jsarha] ANDROID: sched/fair: __pcpu_scope_eenv_cache can be static

Posted by kernel test robot 4 years ago

kernel/sched/fair.c:6738:1: warning: symbol '__pcpu_scope_eenv_cache' was not declared. Should it be static?

Fixes: 0d2a194c5434 ("ANDROID: sched/fair: re-factor energy_diff to use a single (extensible) energy_env")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 kernel/sched/fair.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index dd2b286ea4905..f7a382a602c86 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6735,7 +6735,7 @@ static bool cpu_overutilized(int cpu)
 	return (capacity_of(cpu) * 1024) < (cpu_util(cpu) * capacity_margin);
 }
 
-DEFINE_PER_CPU(struct energy_env, eenv_cache);
+static DEFINE_PER_CPU(struct energy_env, eenv_cache);
 
 /* kernels often have NR_CPUS defined to be much
  * larger than exist in practise on booted systems.