staging: pi433: formatting improvement for multi-line bitwise statement

[PATCH] staging: pi433: formatting improvement for multi-line bitwise statement

Posted by Paulo Miguel Almeida 4 years, 3 months ago

Move bitwise & operator to the end of previous line for better
readability

Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
Meta-comments:

This suggestion was made by Dan Carpenter in a previous patch that ended
up being merged:
https://lore.kernel.org/lkml/20220228063238.GA2794@kadam/
---
 drivers/staging/pi433/pi433_if.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 3f3e863e6cc8..9a55fb29bd54 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -442,8 +442,8 @@ static int pi433_receive(void *data)
 		/* wait for RSSI level to become high */
 		dev_dbg(dev->dev, "rx: going to wait for high RSSI level\n");
 		retval = wait_event_interruptible(dev->rx_wait_queue,
-						  rf69_read_reg(spi, REG_IRQFLAGS1)
-						  & MASK_IRQFLAGS1_RSSI);
+						  rf69_read_reg(spi, REG_IRQFLAGS1) &
+						  MASK_IRQFLAGS1_RSSI);
 		if (retval) /* wait was interrupted */
 			goto abort;
 		dev->interrupt_rx_allowed = false;
-- 
2.34.1

Re: [PATCH] staging: pi433: formatting improvement for multi-line bitwise statement

Posted by Dan Carpenter 4 years, 3 months ago

On Tue, Mar 08, 2022 at 09:19:50PM +1300, Paulo Miguel Almeida wrote:
> Move bitwise & operator to the end of previous line for better
> readability
> 
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> ---
> Meta-comments:
> 
> This suggestion was made by Dan Carpenter in a previous patch that ended
> up being merged:
> https://lore.kernel.org/lkml/20220228063238.GA2794@kadam/

Thanks!

regards,
dan carpenter