iio: frequency: admv1013: remove the always true condition

[PATCH] iio: frequency: admv1013: remove the always true condition

Posted by Muhammad Usama Anjum 4 years, 5 months ago

unsigned int variable is always greater than or equal to zero. Make the
if condition simple.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 drivers/iio/frequency/admv1013.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
index 6cdeb50143af..3f3c478e9baa 100644
--- a/drivers/iio/frequency/admv1013.c
+++ b/drivers/iio/frequency/admv1013.c
@@ -348,7 +348,7 @@ static int admv1013_update_mixer_vgate(struct admv1013_state *st)
 
 	vcm = regulator_get_voltage(st->reg);
 
-	if (vcm >= 0 && vcm < 1800000)
+	if (vcm < 1800000)
 		mixer_vgate = (2389 * vcm / 1000000 + 8100) / 100;
 	else if (vcm > 1800000 && vcm < 2600000)
 		mixer_vgate = (2375 * vcm / 1000000 + 125) / 100;
-- 
2.30.2

Re: [PATCH] iio: frequency: admv1013: remove the always true condition

Posted by Jonathan Cameron 4 years, 5 months ago

On Wed, 5 Jan 2022 02:09:20 +0500
Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:

> unsigned int variable is always greater than or equal to zero. Make the
> if condition simple.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Hi,

+ CC Antoniu and this should have a Fixes tag.

Thanks,

Jonathan

> ---
>  drivers/iio/frequency/admv1013.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
> index 6cdeb50143af..3f3c478e9baa 100644
> --- a/drivers/iio/frequency/admv1013.c
> +++ b/drivers/iio/frequency/admv1013.c
> @@ -348,7 +348,7 @@ static int admv1013_update_mixer_vgate(struct admv1013_state *st)
>  
>  	vcm = regulator_get_voltage(st->reg);
>  
> -	if (vcm >= 0 && vcm < 1800000)
> +	if (vcm < 1800000)
>  		mixer_vgate = (2389 * vcm / 1000000 + 8100) / 100;
>  	else if (vcm > 1800000 && vcm < 2600000)
>  		mixer_vgate = (2375 * vcm / 1000000 + 125) / 100;

Re: [PATCH] iio: frequency: admv1013: remove the always true condition

Posted by Muhammad Usama Anjum 4 years, 5 months ago

On Sat, 2022-01-15 at 18:09 +0000, Jonathan Cameron wrote:
> On Wed, 5 Jan 2022 02:09:20 +0500
> Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
> 
> > unsigned int variable is always greater than or equal to zero. Make the
> > if condition simple.
> > 
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Hi,
> 
> + CC Antoniu and this should have a Fixes tag.
> 
> Thanks,
> 
> Jonathan
> 
Fixes: da35a7b526d9 ("iio: frequency: admv1013: add support for ADMV1013")

Please let me know if I should send a V2 with this tag included.

Thanks,
Usama
> > ---
> >  drivers/iio/frequency/admv1013.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
> > index 6cdeb50143af..3f3c478e9baa 100644
> > --- a/drivers/iio/frequency/admv1013.c
> > +++ b/drivers/iio/frequency/admv1013.c
> > @@ -348,7 +348,7 @@ static int admv1013_update_mixer_vgate(struct admv1013_state *st)
> >  
> > 
> > 
> > 
> >  	vcm = regulator_get_voltage(st->reg);
> >  
> > 
> > 
> > 
> > -	if (vcm >= 0 && vcm < 1800000)
> > +	if (vcm < 1800000)
> >  		mixer_vgate = (2389 * vcm / 1000000 + 8100) / 100;
> >  	else if (vcm > 1800000 && vcm < 2600000)
> >  		mixer_vgate = (2375 * vcm / 1000000 + 125) / 100;
>

Re: [PATCH] iio: frequency: admv1013: remove the always true condition

Posted by Jonathan Cameron 4 years, 5 months ago

On Mon, 17 Jan 2022 13:34:28 +0500
Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:

> On Sat, 2022-01-15 at 18:09 +0000, Jonathan Cameron wrote:
> > On Wed, 5 Jan 2022 02:09:20 +0500
> > Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
> >   
> > > unsigned int variable is always greater than or equal to zero. Make the
> > > if condition simple.
> > > 
> > > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>  
> > Hi,
> > 
> > + CC Antoniu and this should have a Fixes tag.
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> Fixes: da35a7b526d9 ("iio: frequency: admv1013: add support for ADMV1013")
> 
> Please let me know if I should send a V2 with this tag included.

Great thanks an no need to resend.

Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan

> 
> Thanks,
> Usama
> > > ---
> > >  drivers/iio/frequency/admv1013.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1013.c
> > > index 6cdeb50143af..3f3c478e9baa 100644
> > > --- a/drivers/iio/frequency/admv1013.c
> > > +++ b/drivers/iio/frequency/admv1013.c
> > > @@ -348,7 +348,7 @@ static int admv1013_update_mixer_vgate(struct admv1013_state *st)
> > >  
> > > 
> > > 
> > > 
> > >  	vcm = regulator_get_voltage(st->reg);
> > >  
> > > 
> > > 
> > > 
> > > -	if (vcm >= 0 && vcm < 1800000)
> > > +	if (vcm < 1800000)
> > >  		mixer_vgate = (2389 * vcm / 1000000 + 8100) / 100;
> > >  	else if (vcm > 1800000 && vcm < 2600000)
> > >  		mixer_vgate = (2375 * vcm / 1000000 + 125) / 100;  
> >   
> 
>