[PATCH] staging: vt6655: change variable name wTimeStampOff

Tanjuate Brunostar posted 1 patch 3 years, 5 months ago
There is a newer version of this series
drivers/staging/vt6655/rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] staging: vt6655: change variable name wTimeStampOff
Posted by Tanjuate Brunostar 3 years, 5 months ago
The Linux coding style does not allow CamelCase variable naming.

Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
---
 drivers/staging/vt6655/rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 1e5036121665..9bdcf2337235 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -54,7 +54,7 @@
  */
 #define CRITICAL_PACKET_LEN      256
 
-static const unsigned short wTimeStampOff[2][MAX_RATE] = {
+static const unsigned short time_stamp_off[2][MAX_RATE] = {
 	{384, 288, 226, 209, 54, 43, 37, 31, 28, 25, 24, 23}, /* Long Preamble */
 	{384, 192, 130, 113, 54, 43, 37, 31, 28, 25, 24, 23}, /* Short Preamble */
 };
@@ -130,7 +130,7 @@ static __le16 s_uFillDataHead(struct vnt_private *pDevice,
 
 static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
 {
-	return cpu_to_le16(wTimeStampOff[priv->preamble_type % 2]
+	return cpu_to_le16(time_stamp_off[priv->preamble_type % 2]
 							[rate % MAX_RATE]);
 }
 
-- 
2.34.1
Re: [PATCH] staging: vt6655: change variable name wTimeStampOff
Posted by Greg KH 3 years, 5 months ago
On Mon, Oct 31, 2022 at 02:43:58PM +0000, Tanjuate Brunostar wrote:
> The Linux coding style does not allow CamelCase variable naming.

That is a correct statement, but why say that here?  We have
documentation that describes this already :)

Please read the kernel documentation for how to write a good changelog
text and resend this as a v2.

thanks,

greg k-h