[PATCH] ARM: spitz: include header defining input event codes

Dmitry Torokhov posted 1 patch 2 years, 6 months ago
arch/arm/mach-pxa/spitz.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] ARM: spitz: include header defining input event codes
Posted by Dmitry Torokhov 2 years, 6 months ago
The board file for Sharp SL-Cxx00 Series of PDAs uses various KEY_*
defines, but does not include the relevant header directly and instead
relies on other headers to include it indirectly. With the upcoming
cleanup of matrix_keypad.h this indirection is now broken and we should
include the relevant header directly.

Reported: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

If there are no objections to this patch I would like to get it through
my tree. Thanks!

 arch/arm/mach-pxa/spitz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
index 9964729cd428..75634ef6688d 100644
--- a/arch/arm/mach-pxa/spitz.c
+++ b/arch/arm/mach-pxa/spitz.c
@@ -25,6 +25,7 @@
 #include <linux/spi/pxa2xx_spi.h>
 #include <linux/mtd/sharpsl.h>
 #include <linux/mtd/physmap.h>
+#include <linux/input-event-codes.h>
 #include <linux/input/matrix_keypad.h>
 #include <linux/regulator/machine.h>
 #include <linux/io.h>
-- 
2.39.2.637.g21b0678d19-goog


-- 
Dmitry
Re: [PATCH] ARM: spitz: include header defining input event codes
Posted by Arnd Bergmann 2 years, 6 months ago
On Tue, Feb 21, 2023, at 22:59, Dmitry Torokhov wrote:
> The board file for Sharp SL-Cxx00 Series of PDAs uses various KEY_*
> defines, but does not include the relevant header directly and instead
> relies on other headers to include it indirectly. With the upcoming
> cleanup of matrix_keypad.h this indirection is now broken and we should
> include the relevant header directly.
>
> Reported: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> If there are no objections to this patch I would like to get it through
> my tree. Thanks!

Yes, that's fine,

Acked-by: Arnd Bergmann <arnd@arndb.de>