[v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt

[PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt

Posted by qaz6750 lzy 2 years, 1 month ago

I2C6 and I2C7 use the same interrupts, which is incorrect.
In the downstream kernel, I2C7 has interrupts of 608 instead of 607.

Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 18c822abd..214f6e028 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 {
 				dma-names = "tx", "rx";
 				pinctrl-names = "default";
 				pinctrl-0 = <&qup_i2c7_default>;
-				interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
 				#address-cells = <1>;
 				#size-cells = <0>;
 				status = "disabled";
-- 
2.34.1

Re: [PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt

Posted by Krzysztof Kozlowski 2 years, 1 month ago

On 25/07/2023 04:33, qaz6750 lzy wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
> 
> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>

Neither From field nor Signed-off-by have the full name you mentioned
before.

Also: Do not attach (thread) your patchsets to some other threads
(unrelated or older versions). This buries them deep in the mailbox and
might interfere with applying entire sets.

Best regards,
Krzysztof

Re: [PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt

Posted by qaz6750 lzy 2 years, 1 month ago

On 25/07/2023 13:50, qaz6750 lzy wrote:
>On 25/07/2023 04:33, qaz6750 lzy wrote:
>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>> 
>> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
>
>Neither From field nor Signed-off-by have the full name you mentioned
before.
>
>Also: Do not attach (thread) your patchsets to some other threads
>(unrelated or older versions). This buries them deep in the mailbox and
>might interfere with applying entire sets.

I'm sorry, this is my problem. As this is my first time submitting a patch,
I made some mistakes. So, what else do I need to do now? Thank you

I appreciate all your help,
qaz6750 lzy

Re: [PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt

Posted by Konrad Dybcio 2 years, 1 month ago

On 25.07.2023 07:55, qaz6750 lzy wrote:
> On 25/07/2023 13:50, qaz6750 lzy wrote:
>> On 25/07/2023 04:33, qaz6750 lzy wrote:
>>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>>>
>>> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
>>
>> Neither From field nor Signed-off-by have the full name you mentioned
> before.
>>
>> Also: Do not attach (thread) your patchsets to some other threads
>> (unrelated or older versions). This buries them deep in the mailbox and
>> might interfere with applying entire sets.
> 
> I'm sorry, this is my problem. As this is my first time submitting a patch,
> I made some mistakes. So, what else do I need to do now? Thank you
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Konrad