RE: [PATCH 0/3] EDAC: fix error reporting handling during init for

Luck, Tony posted 3 patches 1 month, 2 weeks ago
Only 0 patches received!
There is a newer version of this series
drivers/edac/i7300_edac.c | 33 ++++++++++++++++++++++++---------
RE: [PATCH 0/3] EDAC: fix error reporting handling during init for
Posted by Luck, Tony 1 month, 2 weeks ago
> Since this addresses the same issue with the same simple fix in the same subsystem,
> IMHO it's better to combine this series and the missing fix for driver [1] with your
> previous fix [2] into a single patch, rather than having 5 separate patches.
>
> But please wait for comments from @Luck, Tony and @Borislav Petkov (AMD) on whether
> to use a single patch or multiple patches.
>
> [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/edac/i7300_edac.c#n1092
> [2] https://lore.kernel.org/all/20260429094806.25097-1-tushar.tibude1000@gmail.com/

If the patch was only 5 lines of diff, bundling them all in one patch would be good. But each
is around 30+ lines:

   drivers/edac/i7300_edac.c | 33 ++++++++++++++++++++++++---------

which would make the combined patch a bit bigger than I like.

I'll look at the individual patches and if they are OK I'll pick them up separately.

-Tony
RE: [PATCH 0/3] EDAC: fix error reporting handling during init for
Posted by Zhuo, Qiuxu 1 month, 2 weeks ago
> From: Luck, Tony <tony.luck@intel.com>
> Sent: Friday, May 1, 2026 6:40 AM
> To: Zhuo, Qiuxu <qiuxu.zhuo@intel.com>; Tushar Tibude
> <tushar.tibude1000@gmail.com>; mchehab@kernel.org; bp@alien8.de;
> linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH 0/3] EDAC: fix error reporting handling during init for
> 
> > Since this addresses the same issue with the same simple fix in the
> > same subsystem, IMHO it's better to combine this series and the
> > missing fix for driver [1] with your previous fix [2] into a single patch, rather
> than having 5 separate patches.
> >
> > But please wait for comments from @Luck, Tony and @Borislav Petkov
> > (AMD) on whether to use a single patch or multiple patches.
> >
> > [1]
> > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > /tree/drivers/edac/i7300_edac.c#n1092
> > [2]
> > https://lore.kernel.org/all/20260429094806.25097-1-tushar.tibude1000@g
> > mail.com/
> 
> If the patch was only 5 lines of diff, bundling them all in one patch would be
> good. But each is around 30+ lines:
> 
>    drivers/edac/i7300_edac.c | 33 ++++++++++++++++++++++++---------
> 
> which would make the combined patch a bit bigger than I like.
> 
> I'll look at the individual patches and if they are OK I'll pick them up
> separately.
>

Thanks @Luck, Tony for the comments.

For the patch series, LGTM.

   Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>