> We have ctrl_scope, mon_scope, ctrl_domains. mon_domains. Only one > resource, RDT_RESOURCE_L3 is going to use these fields. Rest of the > resources don't need these fields. But these fields are part of all the > resources. > > I am not too worried about the size of the patch. But, I don't foresee > these fields will be used anytime soon in these resources(MBA. L3. > SMBA). Why add it now? In future we may have to cleanup all these anyways. Babu, I mentioned yesterday that future patches could split struct rdt_resource. I was noodling at doing so back in February. Patches (messy, not finished or fit for consumption) are here (just to give you an idea where things might build from here): git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git rdt_split_resource -Tony
On 6/14/2024 4:40 PM, Luck, Tony wrote: >> We have ctrl_scope, mon_scope, ctrl_domains. mon_domains. Only one >> resource, RDT_RESOURCE_L3 is going to use these fields. Rest of the >> resources don't need these fields. But these fields are part of all the >> resources. >> >> I am not too worried about the size of the patch. But, I don't foresee >> these fields will be used anytime soon in these resources(MBA. L3. >> SMBA). Why add it now? In future we may have to cleanup all these anyways. > > Babu, > > I mentioned yesterday that future patches could split struct rdt_resource. I was noodling > at doing so back in February. Patches (messy, not finished or fit for consumption) are > here (just to give you an idea where things might build from here): > > git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git rdt_split_resource I see, it is similar to splitting the resource (option a. v15-RFC) and little more. I think we should move to that direction eventually. -- Babu Moger
© 2016 - 2025 Red Hat, Inc.