> > Could you please consider this series for inclusion?
>
> Lemme take a look...
>
> > This fix has been merged into v6.13-rc2.
>
> You mean, I should queue the set ontop of -rc2?

v6.13-rc1 may give a lockdep splat when mounting /sys/fs/resctrl
(known CONFIG options to trigger this are:

	PROVE_LOCKING && SELINUX && (EXT4 || BTRFS)

but there may be others).

These resctrl patches are not directly dependent on the fixes that
went into -rc2:

   22465bbac53c blk-mq: move cpuhp callback registering out of q->sysfs_lock
   4bf485a7db5d blk-mq: register cpuhp callback after hctx is added to xarray table

they work ok on top of -rc1  (as long as you ignore the lockdep splat).

I see you already have one patch in TIP x86/cache on top of v6.13-rc1

Your choice whether to rebase that to -rc2 and then apply my series. It
might make testing smoother.

-Tony

On Mon, Dec 09, 2024 at 05:53:12PM +0000, Luck, Tony wrote:
> v6.13-rc1 may give a lockdep splat when mounting /sys/fs/resctrl
> (known CONFIG options to trigger this are:
> 
> 	PROVE_LOCKING && SELINUX && (EXT4 || BTRFS)
> 
> but there may be others).
> 
> These resctrl patches are not directly dependent on the fixes that
> went into -rc2:
> 
>    22465bbac53c blk-mq: move cpuhp callback registering out of q->sysfs_lock
>    4bf485a7db5d blk-mq: register cpuhp callback after hctx is added to xarray table
> 
> they work ok on top of -rc1  (as long as you ignore the lockdep splat).

Thanks for the details.

> I see you already have one patch in TIP x86/cache on top of v6.13-rc1
> 
> Your choice whether to rebase that to -rc2 and then apply my series. It
> might make testing smoother.

Yah, I can rebase. Not worth the hassle of dealing with bogus reports.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

On 12/9/24 11:57, Borislav Petkov wrote:
> On Mon, Dec 09, 2024 at 05:53:12PM +0000, Luck, Tony wrote:
>> v6.13-rc1 may give a lockdep splat when mounting /sys/fs/resctrl
>> (known CONFIG options to trigger this are:
>>
>> 	PROVE_LOCKING && SELINUX && (EXT4 || BTRFS)
>>
>> but there may be others).
>>
>> These resctrl patches are not directly dependent on the fixes that
>> went into -rc2:
>>
>>    22465bbac53c blk-mq: move cpuhp callback registering out of q->sysfs_lock
>>    4bf485a7db5d blk-mq: register cpuhp callback after hctx is added to xarray table
>>
>> they work ok on top of -rc1  (as long as you ignore the lockdep splat).
> 
> Thanks for the details.
> 
>> I see you already have one patch in TIP x86/cache on top of v6.13-rc1
>>
>> Your choice whether to rebase that to -rc2 and then apply my series. It
>> might make testing smoother.
> 
> Yah, I can rebase. Not worth the hassle of dealing with bogus reports.
> 

Sanity tested on AMD system. Changes look good.

Tested-by: Babu Moger <babu.moger@amd.com>

-- 
Thanks
Babu Moger