The USB audio driver does not contain the VID and PID of this sound card, so the driver is not loaded.

[PATCH -next] The USB audio driver does not contain the VID and PID of this sound card, so the driver is not loaded.

Posted by Dicheng Wang 2 years, 9 months ago

From: wangdicheng <wangdicheng@kylinos.cn>

Add relevant information to the quirks-table.h file.
The test passes and the sound source file plays normally.

Cc: stable@vger.kernel.org
Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
---
 sound/usb/quirks-table.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index 874fcf245747..1fb183895da0 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -2802,6 +2802,13 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 	.idProduct = 0x1020,
 },
 
+/* Ktmicro Usb_audio device */
+{
+	.match_flags = USB_DEVICE_ID_MATCH_DEVICE,
+	.idVendor = 0x31b2,
+	.idProduct = 0x0011,
+},
+
 /* QinHeng devices */
 {
 	USB_DEVICE(0x1a86, 0x752d),
-- 
2.25.1

Re: [PATCH -next] The USB audio driver does not contain the VID and PID of this sound card, so the driver is not loaded.

Posted by Takashi Iwai 2 years, 9 months ago

On Fri, 02 Dec 2022 09:29:08 +0100,
Dicheng Wang wrote:
> 
> From: wangdicheng <wangdicheng@kylinos.cn>
> 
> Add relevant information to the quirks-table.h file.
> The test passes and the sound source file plays normally.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>

The code change itself looks good, but could you fix the patch subject
line?  It should have the proper prefix (in this case something like
"ALSA: usb-audio: Blah blah..."), and the text is unnecessarily long.
Please make it concise.

Also, could you give the lsusb -v output of the corresponding device?
Just to make sure.  If possible, it'd be better to use the existing
macro like USB_DEVICE_VENDOR_SPEC() or USB_AUDIO_DEVICE() instead.

thanks,

Takashi

> ---
>  sound/usb/quirks-table.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index 874fcf245747..1fb183895da0 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -2802,6 +2802,13 @@ YAMAHA_DEVICE(0x7010, "UB99"),
>  	.idProduct = 0x1020,
>  },
>  
> +/* Ktmicro Usb_audio device */
> +{
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor = 0x31b2,
> +	.idProduct = 0x0011,
> +},
> +
>  /* QinHeng devices */
>  {
>  	USB_DEVICE(0x1a86, 0x752d),
> -- 
> 2.25.1
>