[v1] RE: [PATCH 6.3 000/364] 6.3.4-rc1 review

RE: [PATCH 6.3 000/364] 6.3.4-rc1 review

Posted by Chris Paterson 2 years, 8 months ago

Hello Greg,

> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Monday, May 22, 2023 8:05 PM
> 
> This is the start of the stable review cycle for the 6.3.4 release.
> There are 364 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Wed, 24 May 2023 19:03:25 +0000.
> Anything received after that time might be too late.

I'm seeing a few build failures with Linux 6.3.4-rc1 (20efcce0526d) due to the drivers/usb/host/xhci.c driver:

drivers/usb/host/xhci.c:497:19: error: static declaration of 'xhci_try_enable_msi' follows non-static declaration
  497 | static inline int xhci_try_enable_msi(struct usb_hcd *hcd)
      |                   ^~~~~~~~~~~~~~~~~~~
In file included from drivers/usb/host/xhci.c:22:
drivers/usb/host/xhci.h:2146:5: note: previous declaration of 'xhci_try_enable_msi' was here
 2146 | int xhci_try_enable_msi(struct usb_hcd *hcd);
      |     ^~~~~~~~~~~~~~~~~~~

Example build failure: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/4328533790#L2178
Pipeline: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/875108293

Commit 78887e3e5f00 ("xhci: Avoid PCI MSI/MSIX interrupt reinitialization at resume") adds the offending code.
I'm only seeing this for the 6.3 rc.

Kind regards, Chris

Re: [PATCH 6.3 000/364] 6.3.4-rc1 review

Posted by Greg Kroah-Hartman 2 years, 8 months ago

On Mon, May 22, 2023 at 08:29:05PM +0000, Chris Paterson wrote:
> Hello Greg,
> 
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Sent: Monday, May 22, 2023 8:05 PM
> > 
> > This is the start of the stable review cycle for the 6.3.4 release.
> > There are 364 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Wed, 24 May 2023 19:03:25 +0000.
> > Anything received after that time might be too late.
> 
> I'm seeing a few build failures with Linux 6.3.4-rc1 (20efcce0526d) due to the drivers/usb/host/xhci.c driver:
> 
> drivers/usb/host/xhci.c:497:19: error: static declaration of 'xhci_try_enable_msi' follows non-static declaration
>   497 | static inline int xhci_try_enable_msi(struct usb_hcd *hcd)
>       |                   ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/usb/host/xhci.c:22:
> drivers/usb/host/xhci.h:2146:5: note: previous declaration of 'xhci_try_enable_msi' was here
>  2146 | int xhci_try_enable_msi(struct usb_hcd *hcd);
>       |     ^~~~~~~~~~~~~~~~~~~
> 
> Example build failure: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/4328533790#L2178
> Pipeline: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/875108293
> 
> Commit 78887e3e5f00 ("xhci: Avoid PCI MSI/MSIX interrupt reinitialization at resume") adds the offending code.
> I'm only seeing this for the 6.3 rc.

Thanks, I've dropped the offending change and will push out a -rc2.

greg k-h

Re: [PATCH 6.3 000/364] 6.3.4-rc1 review

Posted by Sudip Mukherjee 2 years, 8 months ago

Hi Greg,

On Mon, 22 May 2023 at 21:29, Chris Paterson
<Chris.Paterson2@renesas.com> wrote:
>
> Hello Greg,
>
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Sent: Monday, May 22, 2023 8:05 PM
> >
> > This is the start of the stable review cycle for the 6.3.4 release.
> > There are 364 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 24 May 2023 19:03:25 +0000.
> > Anything received after that time might be too late.
>
> I'm seeing a few build failures with Linux 6.3.4-rc1 (20efcce0526d) due to the drivers/usb/host/xhci.c driver:
>
> drivers/usb/host/xhci.c:497:19: error: static declaration of 'xhci_try_enable_msi' follows non-static declaration
>   497 | static inline int xhci_try_enable_msi(struct usb_hcd *hcd)
>       |                   ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/usb/host/xhci.c:22:
> drivers/usb/host/xhci.h:2146:5: note: previous declaration of 'xhci_try_enable_msi' was here
>  2146 | int xhci_try_enable_msi(struct usb_hcd *hcd);
>       |     ^~~~~~~~~~~~~~~~~~~

I am also seeing this same failure on arm (exynos_defconfig and
hisi_defconfig) and mips (cavium_octeon_defconfig)


-- 
Regards
Sudip

RE: [PATCH 6.3 000/364] 6.3.4-rc1 review

Posted by Chris Paterson 2 years, 8 months ago

> From: Chris Paterson <Chris.Paterson2@renesas.com>
> Sent: Monday, May 22, 2023 9:29 PM
> 
> Hello Greg,
> 
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Sent: Monday, May 22, 2023 8:05 PM
> >
> > This is the start of the stable review cycle for the 6.3.4 release.
> > There are 364 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 24 May 2023 19:03:25 +0000.
> > Anything received after that time might be too late.
> 
> I'm seeing a few build failures with Linux 6.3.4-rc1 (20efcce0526d) due to the
> drivers/usb/host/xhci.c driver:

Just to expand on this, the builds that are failing do _not_ have CONFIG_USB_PCI set.

Kind regards, Chris

> 
> drivers/usb/host/xhci.c:497:19: error: static declaration of
> 'xhci_try_enable_msi' follows non-static declaration
>   497 | static inline int xhci_try_enable_msi(struct usb_hcd *hcd)
>       |                   ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/usb/host/xhci.c:22:
> drivers/usb/host/xhci.h:2146:5: note: previous declaration of
> 'xhci_try_enable_msi' was here
>  2146 | int xhci_try_enable_msi(struct usb_hcd *hcd);
>       |     ^~~~~~~~~~~~~~~~~~~
> 
> Example build failure:
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab
> .com%2Fcip-project%2Fcip-testing%2Flinux-stable-rc-ci%2F-
> %2Fjobs%2F4328533790%23L2178&data=05%7C01%7CChris.Paterson2%40re
> nesas.com%7Cee949d7c9a134da2c00b08db5b03423f%7C53d82571da1947e49
> cb4625a166a4a2a%7C0%7C0%7C638203841845350992%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> I6Mn0%3D%7C3000%7C%7C%7C&sdata=BM6vgJJYqirsEZpt5T0Mm5qmQudai
> fCbXerKqHfnUbQ%3D&reserved=0
> Pipeline:
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab
> .com%2Fcip-project%2Fcip-testing%2Flinux-stable-rc-ci%2F-
> %2Fpipelines%2F875108293&data=05%7C01%7CChris.Paterson2%40renesas.
> com%7Cee949d7c9a134da2c00b08db5b03423f%7C53d82571da1947e49cb4625
> a166a4a2a%7C0%7C0%7C638203841845350992%7CUnknown%7CTWFpbGZsb
> 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D%7C3000%7C%7C%7C&sdata=p0q0Dr4l20Tf6cJcb6PFmL3K%2BrIt3R4fVr
> WYFFwMg2o%3D&reserved=0
> 
> Commit 78887e3e5f00 ("xhci: Avoid PCI MSI/MSIX interrupt reinitialization at
> resume") adds the offending code.
> I'm only seeing this for the 6.3 rc.
> 
> Kind regards, Chris