RE: [PATCH 0/6] iwlwifi: Cleaning up deadcode

Posted by Korenblit, Miriam Rachel 1 year ago


> -----Original Message-----
> From: Dr. David Alan Gilbert <linux@treblig.org>
> Sent: Tuesday, 28 January 2025 20:46
> To: Korenblit, Miriam Rachel <miriam.rachel.korenblit@intel.com>;
> kvalo@kernel.org; linux-wireless@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 0/6] iwlwifi: Cleaning up deadcode
> 
> * linux@treblig.org (linux@treblig.org) wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > Hi,
> >   This is a collection of removal of functions that have been used for
> > more than a few years.
> >
> >   There are also a handful of string and one structure removal that
> > are just left overs from a recent commit.
> >
> > They're all entire function/structure/string removal.
> >
> > Build tested only.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> A gentle ping on this just-pre-christmas set please.
> Thanks!
> 
> Dave
> 
> >
> >
> > Dr. David Alan Gilbert (6):
> >   iwlwifi: Remove unused iwl_rx_ant_restriction
> >   iwlwifi: Remove unused iwl_mvm_rx_missed_vap_notif
> >   iwlwifi: Remove unused iwl_mvm_ftm_*_add_pasn_sta functions
> >   iwlwifi: Remove unused iwl_mvm_ftm_add_pasn_sta
> >   iwlwifi: Remove unused iwl_bz_name
> >   iwlwifi: Remove old device data
> >
> >  .../net/wireless/intel/iwlwifi/cfg/22000.c    |   1 -
> >  .../net/wireless/intel/iwlwifi/cfg/ax210.c    |   8 --
> >  drivers/net/wireless/intel/iwlwifi/cfg/bz.c   |   1 -
> >  drivers/net/wireless/intel/iwlwifi/dvm/tt.c   |  11 --
> >  drivers/net/wireless/intel/iwlwifi/dvm/tt.h   |   1 -
> >  .../net/wireless/intel/iwlwifi/iwl-config.h   |   4 -
> >  .../intel/iwlwifi/mvm/ftm-initiator.c         | 101 ------------------
> >  .../intel/iwlwifi/mvm/ftm-responder.c         |  86 ---------------
> >  .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c |  23 ----
> > drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |  12 ---
> > drivers/net/wireless/intel/iwlwifi/mvm/sta.c  |  61 -----------
> >  drivers/net/wireless/intel/iwlwifi/mvm/sta.h  |   4 -
> >  12 files changed, 313 deletions(-)
> >
> > --
> > 2.47.1
> >
> --
>  -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/


Acked-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>

Re: [PATCH 0/6] iwlwifi: Cleaning up deadcode

Posted by Dr. David Alan Gilbert 1 year ago

* Korenblit, Miriam Rachel (miriam.rachel.korenblit@intel.com) wrote:
> 
> 
> > -----Original Message-----
> > From: Dr. David Alan Gilbert <linux@treblig.org>
> > Sent: Tuesday, 28 January 2025 20:46
> > To: Korenblit, Miriam Rachel <miriam.rachel.korenblit@intel.com>;
> > kvalo@kernel.org; linux-wireless@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH 0/6] iwlwifi: Cleaning up deadcode
> > 
> > * linux@treblig.org (linux@treblig.org) wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > >
> > > Hi,
> > >   This is a collection of removal of functions that have been used for
> > > more than a few years.
> > >
> > >   There are also a handful of string and one structure removal that
> > > are just left overs from a recent commit.
> > >
> > > They're all entire function/structure/string removal.
> > >
> > > Build tested only.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > A gentle ping on this just-pre-christmas set please.
> > Thanks!
> > 
> > Dave
> > 
> > >
> > >
> > > Dr. David Alan Gilbert (6):
> > >   iwlwifi: Remove unused iwl_rx_ant_restriction
> > >   iwlwifi: Remove unused iwl_mvm_rx_missed_vap_notif
> > >   iwlwifi: Remove unused iwl_mvm_ftm_*_add_pasn_sta functions
> > >   iwlwifi: Remove unused iwl_mvm_ftm_add_pasn_sta
> > >   iwlwifi: Remove unused iwl_bz_name
> > >   iwlwifi: Remove old device data
> > >
> > >  .../net/wireless/intel/iwlwifi/cfg/22000.c    |   1 -
> > >  .../net/wireless/intel/iwlwifi/cfg/ax210.c    |   8 --
> > >  drivers/net/wireless/intel/iwlwifi/cfg/bz.c   |   1 -
> > >  drivers/net/wireless/intel/iwlwifi/dvm/tt.c   |  11 --
> > >  drivers/net/wireless/intel/iwlwifi/dvm/tt.h   |   1 -
> > >  .../net/wireless/intel/iwlwifi/iwl-config.h   |   4 -
> > >  .../intel/iwlwifi/mvm/ftm-initiator.c         | 101 ------------------
> > >  .../intel/iwlwifi/mvm/ftm-responder.c         |  86 ---------------
> > >  .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c |  23 ----
> > > drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |  12 ---
> > > drivers/net/wireless/intel/iwlwifi/mvm/sta.c  |  61 -----------
> > >  drivers/net/wireless/intel/iwlwifi/mvm/sta.h  |   4 -
> > >  12 files changed, 313 deletions(-)
> > >
> > > --
> > > 2.47.1
> > >
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
> 
> 
> Acked-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>

Thanks!

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/