bus: mhi: host: Add support for a new Quectel Module.

[PATCH] bus: mhi: host: Add support for a new Quectel Module.

Posted by Yonglin Tan 3 years, 12 months ago

From: ylintan <yonglin.tan@outlook.com>

    A new Quectel EM1xx module need to be supported by kernel.
    The module is based on Qualcomm SDX24 platform and the
    configuration should be aligned with EM120 and EM160.

    Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>

Signed-off-by: ylintan <yonglin.tan@outlook.com>
---
 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 8416267..0a6469c 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
+		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
 	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
 		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
-- 
2.7.4

Re: [PATCH] bus: mhi: host: Add support for a new Quectel Module.

Posted by Greg KH 3 years, 12 months ago

On Thu, May 12, 2022 at 05:07:46PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@outlook.com>
> 
>     A new Quectel EM1xx module need to be supported by kernel.
>     The module is based on Qualcomm SDX24 platform and the
>     configuration should be aligned with EM120 and EM160.
> 
>     Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
> 
> Signed-off-by: ylintan <yonglin.tan@outlook.com>

This looks very odd, don't you think?

Please fix it up to be correct, like all other patches that are sent to
the lists.

thanks,

greg k-h