[v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

[PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Posted by Yonglin Tan 3 years, 11 months ago

The product's enumeration align with previous 
Quectel EM120R-GL, so the EM120 FCCL would use 
the same config as Quectel EM120R-GL. 

Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
---

V2:
Fixed the format errors in the patch description.

 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 8416267..0a6469c 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
+		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
 	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
 		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
-- 
2.7.4

Re: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Posted by Manivannan Sadhasivam 3 years, 10 months ago

On Mon, May 16, 2022 at 02:38:29PM +0800, Yonglin Tan wrote:
> The product's enumeration align with previous 
> Quectel EM120R-GL, so the EM120 FCCL would use 
> the same config as Quectel EM120R-GL. 
> 
> Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>

Applied to mhi-next!

Thanks,
Mani

> ---
> 
> V2:
> Fixed the format errors in the patch description.
> 
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Posted by Manivannan Sadhasivam 3 years, 10 months ago

On Mon, May 16, 2022 at 02:38:29PM +0800, Yonglin Tan wrote:
> The product's enumeration align with previous 
> Quectel EM120R-GL, so the EM120 FCCL would use 
> the same config as Quectel EM120R-GL. 
> 
> Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
> 
> V2:
> Fixed the format errors in the patch description.
> 
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Posted by Loic Poulain 3 years, 11 months ago

On Mon, 16 May 2022 at 08:38, Yonglin Tan <yonglin.tan@outlook.com> wrote:
>
> The product's enumeration align with previous
> Quectel EM120R-GL, so the EM120 FCCL would use
> the same config as Quectel EM120R-GL.
>
> Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>

> ---
>
> V2:
> Fixed the format errors in the patch description.
>
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>                 .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>         { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>                 .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +       { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +               .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>         /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>         { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>                 .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
>

回复: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Posted by 谭永林 3 years, 11 months ago

Hi Mani,

Do you have any concern about this patch? 

-----邮件原件-----
发件人: Yonglin Tan <yonglin.tan@outlook.com> 
发送时间: 2022年5月16日 14:38
收件人: mani@kernel.org; loic.poulain@linaro.org; gregkh@linuxfoundation.org; quic_hemantk@quicinc.com
抄送: linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; mhi@lists.linux.dev; Yonglin Tan <yonglin.tan@outlook.com>
主题: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

The product's enumeration align with previous 
Quectel EM120R-GL, so the EM120 FCCL would use 
the same config as Quectel EM120R-GL. 

Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
---

V2:
Fixed the format errors in the patch description.

 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 8416267..0a6469c 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
+		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
 	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
 		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
-- 
2.7.4

Re: 回复: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Posted by mani@kernel.org 3 years, 11 months ago

On Mon, May 23, 2022 at 02:14:15AM +0000, 谭 永林 wrote:
> Hi Mani,
> 
> Do you have any concern about this patch? 

Merge window for 5.19 is open now. I'll start picking up patches once it
closes (approx. 2 weeks).

Thanks for the patience!

Thanks,
Mani

> 
> -----邮件原件-----
> 发件人: Yonglin Tan <yonglin.tan@outlook.com> 
> 发送时间: 2022年5月16日 14:38
> 收件人: mani@kernel.org; loic.poulain@linaro.org; gregkh@linuxfoundation.org; quic_hemantk@quicinc.com
> 抄送: linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; mhi@lists.linux.dev; Yonglin Tan <yonglin.tan@outlook.com>
> 主题: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.
> 
> The product's enumeration align with previous 
> Quectel EM120R-GL, so the EM120 FCCL would use 
> the same config as Quectel EM120R-GL. 
> 
> Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
> ---
> 
> V2:
> Fixed the format errors in the patch description.
> 
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்

回复: 回复: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Posted by 谭永林 3 years, 10 months ago

Dear Mani,

Sorry to bother you again, any progress for this patch? 
Do you need me to resend the patch to you?

-----邮件原件-----
发件人: mani@kernel.org <mani@kernel.org> 
发送时间: 2022年5月24日 21:44
收件人: 谭 永林 <yonglin.tan@outlook.com>
抄送: loic.poulain@linaro.org; gregkh@linuxfoundation.org; quic_hemantk@quicinc.com; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; mhi@lists.linux.dev
主题: Re: 回复: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

On Mon, May 23, 2022 at 02:14:15AM +0000, 谭 永林 wrote:
> Hi Mani,
> 
> Do you have any concern about this patch? 

Merge window for 5.19 is open now. I'll start picking up patches once it closes (approx. 2 weeks).

Thanks for the patience!

Thanks,
Mani

> 
> -----邮件原件-----
> 发件人: Yonglin Tan <yonglin.tan@outlook.com>
> 发送时间: 2022年5月16日 14:38
> 收件人: mani@kernel.org; loic.poulain@linaro.org; 
> gregkh@linuxfoundation.org; quic_hemantk@quicinc.com
> 抄送: linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; 
> mhi@lists.linux.dev; Yonglin Tan <yonglin.tan@outlook.com>
> 主题: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.
> 
> The product's enumeration align with previous Quectel EM120R-GL, so 
> the EM120 FCCL would use the same config as Quectel EM120R-GL.
> 
> Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
> ---
> 
> V2:
> Fixed the format errors in the patch description.
> 
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c 
> b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்