HID: apple: improvements for code readability

[PATCH 0/2] HID: apple: improvements for code readability

Posted by Aditya Garg 1 year, 2 months ago

Hi

This small patch series aims to improve the code readability in hid-apple.

The first patch moves the backlight report structs, that were incorrectly
placed between the translation tables, to other related backlight structs.

The second patch makes use of switch case statements for the ever
increasing lengthy device table for fn translation.

Aditya Garg (2):
  HID: apple: move backlight report structs alongwith other backlight
    structs
  HID: apple: use switch case to set fn translation table

 drivers/hid/hid-apple.c | 100 ++++++++++++++++++++++------------------
 1 file changed, 54 insertions(+), 46 deletions(-)

-- 
2.43.0

Re: [PATCH 0/2] HID: apple: improvements for code readability

Posted by Aditya Garg 1 year, 2 months ago


> On 4 Mar 2025, at 2:42 PM, Aditya Garg <gargaditya08@live.com> wrote:
> 
> Hi
> 
> This small patch series aims to improve the code readability in hid-apple.
> 
> The first patch moves the backlight report structs, that were incorrectly
> placed between the translation tables, to other related backlight structs.
> 
> The second patch makes use of switch case statements for the ever
> increasing lengthy device table for fn translation.
> 
> Aditya Garg (2):
>  HID: apple: move backlight report structs alongwith other backlight
>    structs
>  HID: apple: use switch case to set fn translation table
> 
> drivers/hid/hid-apple.c | 100 ++++++++++++++++++++++------------------
> 1 file changed, 54 insertions(+), 46 deletions(-)
> 
> -- 
> 2.43.0
> 

A v2 with more patches has been sent here:

https://lore.kernel.org/linux-input/A4FBEA54-C7BA-4864-9C4E-E41933D81FB0@live.com/T/#t


There were conflicting patches sent upstream by another person, so its best to combine them in one series, making things easier for both of us.