MAINTAINERS: fix DWMAC S32 entry

[PATCH] MAINTAINERS: fix DWMAC S32 entry

Posted by Russell King (Oracle) 10 months ago

Using L: with more than a bare email address causes getmaintainer.pl
to be unable to parse the entry. Fix this by doing as other entries
that use this email address and convert it to an R: entry.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index de81a3d68396..7da5d2df1b45 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2877,7 +2877,7 @@ F:	drivers/pinctrl/nxp/
 
 ARM/NXP S32G/S32R DWMAC ETHERNET DRIVER
 M:	Jan Petrous <jan.petrous@oss.nxp.com>
-L:	NXP S32 Linux Team <s32@nxp.com>
+R:	NXP S32 Linux Team <s32@nxp.com>
 S:	Maintained
 F:	Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml
 F:	drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c
-- 
2.30.2

Re: [PATCH] MAINTAINERS: fix DWMAC S32 entry

Posted by Jakub Kicinski 10 months ago

On Tue, 18 Feb 2025 09:23:14 +0000 Russell King (Oracle) wrote:
> Using L: with more than a bare email address causes getmaintainer.pl
> to be unable to parse the entry. Fix this by doing as other entries
> that use this email address and convert it to an R: entry.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index de81a3d68396..7da5d2df1b45 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2877,7 +2877,7 @@ F:	drivers/pinctrl/nxp/
>  
>  ARM/NXP S32G/S32R DWMAC ETHERNET DRIVER
>  M:	Jan Petrous <jan.petrous@oss.nxp.com>
> -L:	NXP S32 Linux Team <s32@nxp.com>
> +R:	NXP S32 Linux Team <s32@nxp.com>
>  S:	Maintained

I had to look thru old commits, 8b0f64b113d61 specifically.
Can we also strip the "NXP S32 Linux Team"
It's pretty obvious from s32@nxp.com that it's a group address,
and this way our scripts will know that this is not a real reviewer.
-- 
pw-bot: cr

Re: [PATCH] MAINTAINERS: fix DWMAC S32 entry

Posted by Russell King (Oracle) 10 months ago

On Thu, Feb 20, 2025 at 03:22:48PM -0800, Jakub Kicinski wrote:
> On Tue, 18 Feb 2025 09:23:14 +0000 Russell King (Oracle) wrote:
> > Using L: with more than a bare email address causes getmaintainer.pl
> > to be unable to parse the entry. Fix this by doing as other entries
> > that use this email address and convert it to an R: entry.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > ---
> >  MAINTAINERS | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index de81a3d68396..7da5d2df1b45 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2877,7 +2877,7 @@ F:	drivers/pinctrl/nxp/
> >  
> >  ARM/NXP S32G/S32R DWMAC ETHERNET DRIVER
> >  M:	Jan Petrous <jan.petrous@oss.nxp.com>
> > -L:	NXP S32 Linux Team <s32@nxp.com>
> > +R:	NXP S32 Linux Team <s32@nxp.com>
> >  S:	Maintained
> 
> I had to look thru old commits, 8b0f64b113d61 specifically.
> Can we also strip the "NXP S32 Linux Team"
> It's pretty obvious from s32@nxp.com that it's a group address,
> and this way our scripts will know that this is not a real reviewer.

Right now, the situation is:

$ grep s32@nxp.com MAINTAINERS
R:      NXP S32 Linux Team <s32@nxp.com>
L:      NXP S32 Linux Team <s32@nxp.com>
R:      NXP S32 Linux Team <s32@nxp.com>
L:      s32@nxp.com

and the approach that has been taken in the past is:

-L:     NXP S32 Linux Team <s32@nxp.com>
+R:     NXP S32 Linux Team <s32@nxp.com>

in commit bb2de9b04942 ("MAINTAINERS: fix list entries with display names")

However, commit 98dcb872779f ("ARM: s32c: update MAINTAINERS entry") did
the reverse for the "ARM/NXP S32G ARCHITECTURE" entry breaking that and
adding a new instance of this breakage elsewhere.

It seems these are just going to flip back and forth, so I don't think
I can be bothered to try to fix it, and will modify my own scripts to
eliminate the blank entry in get_maintainers output because of this.
(In other words, s32@nxp.com will *not* be Cc'd for any patches I send.)


-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH] MAINTAINERS: fix DWMAC S32 entry

Posted by Jakub Kicinski 10 months ago

On Fri, 21 Feb 2025 00:22:12 +0000 Russell King (Oracle) wrote:
> Right now, the situation is:
> 
> $ grep s32@nxp.com MAINTAINERS
> R:      NXP S32 Linux Team <s32@nxp.com>
> L:      NXP S32 Linux Team <s32@nxp.com>
> R:      NXP S32 Linux Team <s32@nxp.com>
> L:      s32@nxp.com
> 
> and the approach that has been taken in the past is:
> 
> -L:     NXP S32 Linux Team <s32@nxp.com>
> +R:     NXP S32 Linux Team <s32@nxp.com>
> 
> in commit bb2de9b04942 ("MAINTAINERS: fix list entries with display names")
> 
> However, commit 98dcb872779f ("ARM: s32c: update MAINTAINERS entry") did
> the reverse for the "ARM/NXP S32G ARCHITECTURE" entry breaking that and
> adding a new instance of this breakage elsewhere.
> 
> It seems these are just going to flip back and forth, so I don't think
> I can be bothered to try to fix it, and will modify my own scripts to
> eliminate the blank entry in get_maintainers output because of this.
> (In other words, s32@nxp.com will *not* be Cc'd for any patches I send.)

Literally would have taken you less time to fix it how I asked than
type this email :/

Re: [PATCH] MAINTAINERS: fix DWMAC S32 entry

Posted by Russell King (Oracle) 10 months ago

On Thu, Feb 20, 2025 at 04:48:19PM -0800, Jakub Kicinski wrote:
> On Fri, 21 Feb 2025 00:22:12 +0000 Russell King (Oracle) wrote:
> > Right now, the situation is:
> > 
> > $ grep s32@nxp.com MAINTAINERS
> > R:      NXP S32 Linux Team <s32@nxp.com>
> > L:      NXP S32 Linux Team <s32@nxp.com>
> > R:      NXP S32 Linux Team <s32@nxp.com>
> > L:      s32@nxp.com
> > 
> > and the approach that has been taken in the past is:
> > 
> > -L:     NXP S32 Linux Team <s32@nxp.com>
> > +R:     NXP S32 Linux Team <s32@nxp.com>
> > 
> > in commit bb2de9b04942 ("MAINTAINERS: fix list entries with display names")
> > 
> > However, commit 98dcb872779f ("ARM: s32c: update MAINTAINERS entry") did
> > the reverse for the "ARM/NXP S32G ARCHITECTURE" entry breaking that and
> > adding a new instance of this breakage elsewhere.
> > 
> > It seems these are just going to flip back and forth, so I don't think
> > I can be bothered to try to fix it, and will modify my own scripts to
> > eliminate the blank entry in get_maintainers output because of this.
> > (In other words, s32@nxp.com will *not* be Cc'd for any patches I send.)
> 
> Literally would have taken you less time to fix it how I asked than
> type this email :/

My point is that "fixing" it will only get unfixed later - as can be
seen from the history of the s32 entries already present. They flip-flop
between R: and L: as people's ideas about what is correct change.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH] MAINTAINERS: fix DWMAC S32 entry

Posted by Andrew Lunn 10 months ago

On Tue, Feb 18, 2025 at 09:23:14AM +0000, Russell King (Oracle) wrote:
> Using L: with more than a bare email address causes getmaintainer.pl
> to be unable to parse the entry. Fix this by doing as other entries
> that use this email address and convert it to an R: entry.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Fixes: 6bc6234cbd5e ("MAINTAINERS: Add Jan Petrous as the NXP S32G/R DWMAC driver maintainer")

Probably should go to net, not net-next.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew