RE: wlwifi AX201: WARN_ON in iwl_mvm_mld_mac_ctxt_cmd_common repeated UMAC FW crashes on 6.16-rc2

Korenblit, Miriam Rachel posted 1 patch 3 months, 2 weeks ago
drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
RE: wlwifi AX201: WARN_ON in iwl_mvm_mld_mac_ctxt_cmd_common repeated UMAC FW crashes on 6.16-rc2
Posted by Korenblit, Miriam Rachel 3 months, 2 weeks ago
> > VG
> > Demian Tometzki
> 
> Hi together,
> 
> I identified commit 83f3ac2848b46e3e5af5d06b5f176c as the cause of the issue.
> After reverting it, the system is working again.
> 
> Best regards
> Damian

Hi Damian,

Thanks for the report!

Can you test the attached fix?

Miri
From 8c39331d01db0f1047f389d89f88516db1ef90e1 Mon Sep 17 00:00:00 2001
From: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Date: Sun, 22 Jun 2025 23:42:04 +0300
Subject: [PATCH] wifi: iwlwifi: mvm: assume '1' as the default mac_config_cmd
 version
Organization: Intel Israel (74) Limited

Unfortunately, FWs of some devices don't have the version of the
iwl_mac_config_cmd defined in the TLVs. We send 0 as the 'def argument
to  iwl_fw_lookup_cmd_ver, so for such FWs, the return value will be 0,
leading to a warning, and to not sending the command.

Fix this by assuming that the default version is 1.

Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Change-Id: Iba487b3addfad95e51c7d5ad79c962be3eab046f
---
 drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c
index 3c255ae916c8..48ab6a2a98cc 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c
@@ -32,7 +32,7 @@ static void iwl_mvm_mld_mac_ctxt_cmd_common(struct iwl_mvm *mvm,
 	unsigned int link_id;
 	int cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw,
 					    WIDE_ID(MAC_CONF_GROUP,
-						    MAC_CONFIG_CMD), 0);
+						    MAC_CONFIG_CMD), 1);
 
 	if (WARN_ON(cmd_ver < 1 || cmd_ver > 3))
 		return;
-- 
2.34.1