This series contains two small fixes for the Greybus audio manager:

1) Fix a NULL dereference in gb_audio_manager_get_module().
2) Drop a stale TODO in the module release callback.

Both are correctness / cleanup fixes with no functional change beyond
preventing crashes.

Thanks,
Hardik

On Fri, Feb 20, 2026 at 05:41:50AM +0000, Hardik Phalet wrote:
> This series contains two small fixes for the Greybus audio manager:
> 
> 1) Fix a NULL dereference in gb_audio_manager_get_module().
> 2) Drop a stale TODO in the module release callback.
> 
> Both are correctness / cleanup fixes with no functional change beyond
> preventing crashes.
> 
> Thanks,
> Hardik

> From b381767672023234e6d18482a7b68aeb78fdf2b9 Mon Sep 17 00:00:00 2001
> From: Hardik Phalet <hardik.phalet@pm.me>
> Date: Fri, 20 Feb 2026 11:00:41 +0530
> Subject: [PATCH v1 0/2] *** SUBJECT HERE ***
> 
> *** BLURB HERE ***


No blurb?

Apologies, resending via git email for proper formatting.

Empty Message

On Fri, Feb 20, 2026 at 05:44:19AM +0000, Hardik Phalet wrote:
> Empty Message

> From 3b496a0daa8cbbbe50a7a09e6daf7bb4d8e6e9e5 Mon Sep 17 00:00:00 2001
> From: Hardik Phalet <hardik.phalet@pm.me>
> Date: Fri, 20 Feb 2026 10:41:49 +0530
> Subject: [PATCH v1 1/2] staging: greybus: audio: fix NULL dereference in
>  gb_audio_manager_get_module()
> 
> gb_audio_manager_get_module() calls gb_audio_manager_get_locked(), which
> can return NULL when the requested id does not exist. The returned
> pointer is dereferenced unconditionally via kobject_get(), leading to a
> NULL pointer dereference.
> 
> Only take a kobject reference when the module is found.
> 
> Signed-off-by: Hardik Phalet <hardik.phalet@pm.me>
> ---
>  drivers/staging/greybus/audio_manager.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index 27ca5f796c5f..1da8804e61ca 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -111,7 +111,8 @@ struct gb_audio_manager_module *gb_audio_manager_get_module(int id)

I don't think the gb_audio_manager_get_module() function is ever called.

Otherwise probably this would need a Fixes tag.

regards,
dan carpenter

On Fri, Feb 20, 2026 at 05:44:19AM +0000, Hardik Phalet wrote:
> Empty Message

Something went wrong, please resend these as a v2.

thanks,

greg k-h

Empty Message