1. Patchew
  2. linux
  3. View series

RE: [PATCH 0/2] Fix boot hang issue on Ampere Emag server

Justin He posted 2 patches 3 years, 2 months ago
Only 0 patches received!
There is a newer version of this series
RE: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Justin He 3 years, 2 months ago 
Hi Jason

> -----Original Message-----
> From: Jason A. Donenfeld <Jason@zx2c4.com>
> Sent: Wednesday, February 1, 2023 2:23 AM
> To: Justin He <Justin.He@arm.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>; Huacai Chen <chenhuacai@kernel.org>;
> linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; Alexandru Elisei
> <Alexandru.Elisei@arm.com>
> Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
>
> On Tue, Jan 31, 2023 at 03:21:39PM +0000, Justin He wrote:
> > Hi Ard,
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ardb@kernel.org>
> > > Sent: Tuesday, January 31, 2023 3:19 PM
> > > To: Justin He <Justin.He@arm.com>; Jason A. Donenfeld
> > > <Jason@zx2c4.com>
> > > Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; Alexandru Elisei
> > > <Alexandru.Elisei@arm.com>
> > > Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> > >
> > > (cc Jason for awareness)
> > >
> > > On Tue, 31 Jan 2023 at 05:04, Jia He <justin.he@arm.com> wrote:
> > > >
> > > > I met a hung task warning and then kernel was hung forever with
> > > > latest kernel on an Ampere Emag server.
> > > >
> > > > The root cause is kernel was hung  when invoking an efi rts call
> > > > to set the RandomSeed variable during the booting stage. The
> > > > arch_efi_call_virt call (set_variable) was never returned and then
> > > > caused the
> > > hung task error.
> > > >
> > >
> > > Given that EFI variables work on this platform (as far as I know),
> > > the problem may be that we are calling SetVariable() too early.
> > >
> > > Could you double check whether setting variables works as expected?
> > > You can use efibootmgr -t 10 as root (for example) to set the boot
> > > timeout, and check whether the new value is retained after a reboot
> > > (efibootmgr will print the current value for you)
> > >
> > > Could you also please share the kernel log up until the point where it
> hangs?
> > >
> > The set_variable seems to be ok in 5.19+:
> > root@:~# efibootmgr -t 10
> > BootCurrent: 0000
> > Timeout: 10 seconds
>
> I think what we want to learn is whether efibootmgr -t 10 works in the latest
> RC. If not, it would suggest the issue isn't with the seed setting, but with some
> other unrelated change.
>
> Can you run efibootmgr -t 10 (or whatever) again on a kernel where you've
> commented out these lines in efi.c inside of efisubsys_init():
>
>     if (efi_rt_services_supported(EFI_RT_SUPPORTED_SET_VARIABLE))
>         execute_with_initialized_rng(&refresh_nv_rng_seed_nb);
>
> -->
>
>     // if (efi_rt_services_supported(EFI_RT_SUPPORTED_SET_VARIABLE))
>     //     execute_with_initialized_rng(&refresh_nv_rng_seed_nb);
>
As your suggested (comment above execute_with_initialized_rng in latest kernel):
The efibootmgr -t X will be hung. Looks like one certain commit before your patch
broke the set_variable efi call. I will dig into the further debug and tell you the result.

---
Cheers,
Justin.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
RE: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Justin He 3 years, 2 months ago 
Hi Ard

> -----Original Message-----
[...]
> As your suggested (comment above execute_with_initialized_rng in latest
> kernel):
> The efibootmgr -t X will be hung. Looks like one certain commit before your
> patch broke the set_variable efi call. I will dig into the further debug and tell
> you the result.

The root cause of the hung IMO might be similar to 
commit 550b33cfd445296868a478e8413ffb2e963eed32
Author: Ard Biesheuvel <ardb@kernel.org>
Date:   Thu Nov 10 10:36:20 2022 +0100

    arm64: efi: Force the use of SetVirtualAddressMap() on Altra machines

Do you agree with the idea if I add Ampere ”eMAG” machine into the list of
Using SetVirtualAddressMap() forcibly?

Please note that even in previous kernel patch, the efibootmgr -t 10 will make
kernel hung if I passed "efi=novamap" to the boot parameter.


--
Cheers,
Justin (Jia He)
Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Ard Biesheuvel 3 years, 2 months ago 
On Tue, 7 Feb 2023 at 04:21, Justin He <Justin.He@arm.com> wrote:
>
> Hi Ard
>
> > -----Original Message-----
> [...]
> > As your suggested (comment above execute_with_initialized_rng in latest
> > kernel):
> > The efibootmgr -t X will be hung. Looks like one certain commit before your
> > patch broke the set_variable efi call. I will dig into the further debug and tell
> > you the result.
>
> The root cause of the hung IMO might be similar to
> commit 550b33cfd445296868a478e8413ffb2e963eed32
> Author: Ard Biesheuvel <ardb@kernel.org>
> Date:   Thu Nov 10 10:36:20 2022 +0100
>
>     arm64: efi: Force the use of SetVirtualAddressMap() on Altra machines
>
> Do you agree with the idea if I add Ampere ”eMAG” machine into the list of
> Using SetVirtualAddressMap() forcibly?
>
> Please note that even in previous kernel patch, the efibootmgr -t 10 will make
> kernel hung if I passed "efi=novamap" to the boot parameter.
>

Interesting. What does dmidecode return for the family in the type 1 record?
RE: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Justin He 3 years, 2 months ago 

> -----Original Message-----
[..]
> > The root cause of the hung IMO might be similar to commit
> > 550b33cfd445296868a478e8413ffb2e963eed32
> > Author: Ard Biesheuvel <ardb@kernel.org>
> > Date:   Thu Nov 10 10:36:20 2022 +0100
> >
> >     arm64: efi: Force the use of SetVirtualAddressMap() on Altra
> > machines
> >
> > Do you agree with the idea if I add Ampere ”eMAG” machine into the
> > list of Using SetVirtualAddressMap() forcibly?
> >
> > Please note that even in previous kernel patch, the efibootmgr -t 10
> > will make kernel hung if I passed "efi=novamap" to the boot parameter.
> >
> 
> Interesting. What does dmidecode return for the family in the type 1 record?

# dmidecode |grep -i family
        Family: eMAG
        Family: ARMv8

The full dmidecode log is at https://pastebin.com/M3MAJtUG


--
Cheers,
Justin (Jia He)
Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Ard Biesheuvel 3 years, 2 months ago 
On Tue, 7 Feb 2023 at 09:49, Justin He <Justin.He@arm.com> wrote:
>
>
>
> > -----Original Message-----
> [..]
> > > The root cause of the hung IMO might be similar to commit
> > > 550b33cfd445296868a478e8413ffb2e963eed32
> > > Author: Ard Biesheuvel <ardb@kernel.org>
> > > Date:   Thu Nov 10 10:36:20 2022 +0100
> > >
> > >     arm64: efi: Force the use of SetVirtualAddressMap() on Altra
> > > machines
> > >
> > > Do you agree with the idea if I add Ampere ”eMAG” machine into the
> > > list of Using SetVirtualAddressMap() forcibly?
> > >
> > > Please note that even in previous kernel patch, the efibootmgr -t 10
> > > will make kernel hung if I passed "efi=novamap" to the boot parameter.
> > >
> >
> > Interesting. What does dmidecode return for the family in the type 1 record?
>
> # dmidecode |grep -i family
>         Family: eMAG
>         Family: ARMv8
>
> The full dmidecode log is at https://pastebin.com/M3MAJtUG
>

OK please try this:

diff --git a/drivers/firmware/efi/libstub/arm64.c
b/drivers/firmware/efi/libstub/arm64.c
index ff2d18c42ee74979..fae930dec82be7c6 100644
--- a/drivers/firmware/efi/libstub/arm64.c
+++ b/drivers/firmware/efi/libstub/arm64.c
@@ -22,7 +22,8 @@ static bool system_needs_vamap(void)
         * Ampere Altra machines crash in SetTime() if SetVirtualAddressMap()
         * has not been called prior.
         */
-       if (!type1_family || strcmp(type1_family, "Altra"))
+       if (!type1_family ||
+           (strcmp(type1_family, "Altra") && strcmp(type1_family, "eMAG")))
                return false;

        efi_warn("Working around broken SetVirtualAddressMap()\n");
RE: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Justin He 3 years, 2 months ago 
Hi Ard

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Tuesday, February 7, 2023 4:54 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> linux-kernel@vger.kernel.org; Alexandru Elisei <Alexandru.Elisei@arm.com>;
> Jason A. Donenfeld <Jason@zx2c4.com>; nd <nd@arm.com>
> Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> 
> On Tue, 7 Feb 2023 at 09:49, Justin He <Justin.He@arm.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > [..]
> > > > The root cause of the hung IMO might be similar to commit
> > > > 550b33cfd445296868a478e8413ffb2e963eed32
> > > > Author: Ard Biesheuvel <ardb@kernel.org>
> > > > Date:   Thu Nov 10 10:36:20 2022 +0100
> > > >
> > > >     arm64: efi: Force the use of SetVirtualAddressMap() on Altra
> > > > machines
> > > >
> > > > Do you agree with the idea if I add Ampere ”eMAG” machine into the
> > > > list of Using SetVirtualAddressMap() forcibly?
> > > >
> > > > Please note that even in previous kernel patch, the efibootmgr -t
> > > > 10 will make kernel hung if I passed "efi=novamap" to the boot
> parameter.
> > > >
> > >
> > > Interesting. What does dmidecode return for the family in the type 1
> record?
> >
> > # dmidecode |grep -i family
> >         Family: eMAG
> >         Family: ARMv8
> >
> > The full dmidecode log is at https://pastebin.com/M3MAJtUG
> >
> 
> OK please try this:
> 
> diff --git a/drivers/firmware/efi/libstub/arm64.c
> b/drivers/firmware/efi/libstub/arm64.c
> index ff2d18c42ee74979..fae930dec82be7c6 100644
> --- a/drivers/firmware/efi/libstub/arm64.c
> +++ b/drivers/firmware/efi/libstub/arm64.c
> @@ -22,7 +22,8 @@ static bool system_needs_vamap(void)
>          * Ampere Altra machines crash in SetTime() if
> SetVirtualAddressMap()
>          * has not been called prior.
>          */
> -       if (!type1_family || strcmp(type1_family, "Altra"))
> +       if (!type1_family ||
> +           (strcmp(type1_family, "Altra") && strcmp(type1_family,
> + "eMAG")))
>                 return false;
> 
>         efi_warn("Working around broken SetVirtualAddressMap()\n");

Yes, it works on my eMAG server: the kernel boots.
Other than efibootmgr failure. But I noticed this efibootmgr failure even before
Commit d3549a938b7 ("avoid SetVirtualAddressMap() when possible ")

root@:~/linux# efibootmgr -t 9; efibootmgr -t 5;
Could not set Timeout: Input/output error
Could not set Timeout: Input/output error


--
Cheers,
Justin (Jia He)
Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Ard Biesheuvel 3 years, 2 months ago 
On Tue, 7 Feb 2023 at 10:03, Justin He <Justin.He@arm.com> wrote:
>
> Hi Ard
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Tuesday, February 7, 2023 4:54 PM
> > To: Justin He <Justin.He@arm.com>
> > Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Alexandru Elisei <Alexandru.Elisei@arm.com>;
> > Jason A. Donenfeld <Jason@zx2c4.com>; nd <nd@arm.com>
> > Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> >
> > On Tue, 7 Feb 2023 at 09:49, Justin He <Justin.He@arm.com> wrote:
> > >
> > >
> > >
> > > > -----Original Message-----
> > > [..]
> > > > > The root cause of the hung IMO might be similar to commit
> > > > > 550b33cfd445296868a478e8413ffb2e963eed32
> > > > > Author: Ard Biesheuvel <ardb@kernel.org>
> > > > > Date:   Thu Nov 10 10:36:20 2022 +0100
> > > > >
> > > > >     arm64: efi: Force the use of SetVirtualAddressMap() on Altra
> > > > > machines
> > > > >
> > > > > Do you agree with the idea if I add Ampere ”eMAG” machine into the
> > > > > list of Using SetVirtualAddressMap() forcibly?
> > > > >
> > > > > Please note that even in previous kernel patch, the efibootmgr -t
> > > > > 10 will make kernel hung if I passed "efi=novamap" to the boot
> > parameter.
> > > > >
> > > >
> > > > Interesting. What does dmidecode return for the family in the type 1
> > record?
> > >
> > > # dmidecode |grep -i family
> > >         Family: eMAG
> > >         Family: ARMv8
> > >
> > > The full dmidecode log is at https://pastebin.com/M3MAJtUG
> > >
> >
> > OK please try this:
> >
> > diff --git a/drivers/firmware/efi/libstub/arm64.c
> > b/drivers/firmware/efi/libstub/arm64.c
> > index ff2d18c42ee74979..fae930dec82be7c6 100644
> > --- a/drivers/firmware/efi/libstub/arm64.c
> > +++ b/drivers/firmware/efi/libstub/arm64.c
> > @@ -22,7 +22,8 @@ static bool system_needs_vamap(void)
> >          * Ampere Altra machines crash in SetTime() if
> > SetVirtualAddressMap()
> >          * has not been called prior.
> >          */
> > -       if (!type1_family || strcmp(type1_family, "Altra"))
> > +       if (!type1_family ||
> > +           (strcmp(type1_family, "Altra") && strcmp(type1_family,
> > + "eMAG")))
> >                 return false;
> >
> >         efi_warn("Working around broken SetVirtualAddressMap()\n");
>
> Yes, it works on my eMAG server: the kernel boots.
> Other than efibootmgr failure. But I noticed this efibootmgr failure even before
> Commit d3549a938b7 ("avoid SetVirtualAddressMap() when possible ")
>
> root@:~/linux# efibootmgr -t 9; efibootmgr -t 5;
> Could not set Timeout: Input/output error
> Could not set Timeout: Input/output error
>

Do you get any [Firmware Bug] lines in the kernel log?
RE: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Justin He 3 years, 2 months ago 

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Tuesday, February 7, 2023 5:04 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> linux-kernel@vger.kernel.org; Alexandru Elisei <Alexandru.Elisei@arm.com>;
> Jason A. Donenfeld <Jason@zx2c4.com>; nd <nd@arm.com>
> Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> 
> On Tue, 7 Feb 2023 at 10:03, Justin He <Justin.He@arm.com> wrote:
> >
> > Hi Ard
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ardb@kernel.org>
> > > Sent: Tuesday, February 7, 2023 4:54 PM
> > > To: Justin He <Justin.He@arm.com>
> > > Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; Alexandru Elisei
> > > <Alexandru.Elisei@arm.com>; Jason A. Donenfeld <Jason@zx2c4.com>; nd
> > > <nd@arm.com>
> > > Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> > >
> > > On Tue, 7 Feb 2023 at 09:49, Justin He <Justin.He@arm.com> wrote:
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > [..]
> > > > > > The root cause of the hung IMO might be similar to commit
> > > > > > 550b33cfd445296868a478e8413ffb2e963eed32
> > > > > > Author: Ard Biesheuvel <ardb@kernel.org>
> > > > > > Date:   Thu Nov 10 10:36:20 2022 +0100
> > > > > >
> > > > > >     arm64: efi: Force the use of SetVirtualAddressMap() on
> > > > > > Altra machines
> > > > > >
> > > > > > Do you agree with the idea if I add Ampere ”eMAG” machine into
> > > > > > the list of Using SetVirtualAddressMap() forcibly?
> > > > > >
> > > > > > Please note that even in previous kernel patch, the efibootmgr
> > > > > > -t
> > > > > > 10 will make kernel hung if I passed "efi=novamap" to the boot
> > > parameter.
> > > > > >
> > > > >
> > > > > Interesting. What does dmidecode return for the family in the
> > > > > type 1
> > > record?
> > > >
> > > > # dmidecode |grep -i family
> > > >         Family: eMAG
> > > >         Family: ARMv8
> > > >
> > > > The full dmidecode log is at https://pastebin.com/M3MAJtUG
> > > >
> > >
> > > OK please try this:
> > >
> > > diff --git a/drivers/firmware/efi/libstub/arm64.c
> > > b/drivers/firmware/efi/libstub/arm64.c
> > > index ff2d18c42ee74979..fae930dec82be7c6 100644
> > > --- a/drivers/firmware/efi/libstub/arm64.c
> > > +++ b/drivers/firmware/efi/libstub/arm64.c
> > > @@ -22,7 +22,8 @@ static bool system_needs_vamap(void)
> > >          * Ampere Altra machines crash in SetTime() if
> > > SetVirtualAddressMap()
> > >          * has not been called prior.
> > >          */
> > > -       if (!type1_family || strcmp(type1_family, "Altra"))
> > > +       if (!type1_family ||
> > > +           (strcmp(type1_family, "Altra") && strcmp(type1_family,
> > > + "eMAG")))
> > >                 return false;
> > >
> > >         efi_warn("Working around broken SetVirtualAddressMap()\n");
> >
> > Yes, it works on my eMAG server: the kernel boots.
> > Other than efibootmgr failure. But I noticed this efibootmgr failure
> > even before Commit d3549a938b7 ("avoid SetVirtualAddressMap() when
> > possible ")
> >
> > root@:~/linux# efibootmgr -t 9; efibootmgr -t 5; Could not set
> > Timeout: Input/output error Could not set Timeout: Input/output error
> >
> 
> Do you get any [Firmware Bug] lines in the kernel log?

No, 
I built the kernel based on:
commit d2d11f342b179f1894a901f143ec7c008caba43e (HEAD -> master, origin/master, origin/HEAD)
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Feb 5 17:17:10 2023 -0800

    Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

Are you worried about your sync exception fixup patch? I think it has been included.


--
Cheers,
Justin (Jia He)
Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Ard Biesheuvel 3 years, 2 months ago 
On Tue, 7 Feb 2023 at 10:08, Justin He <Justin.He@arm.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Tuesday, February 7, 2023 5:04 PM
> > To: Justin He <Justin.He@arm.com>
> > Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Alexandru Elisei <Alexandru.Elisei@arm.com>;
> > Jason A. Donenfeld <Jason@zx2c4.com>; nd <nd@arm.com>
> > Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> >
> > On Tue, 7 Feb 2023 at 10:03, Justin He <Justin.He@arm.com> wrote:
> > >
> > > Hi Ard
> > >
> > > > -----Original Message-----
> > > > From: Ard Biesheuvel <ardb@kernel.org>
> > > > Sent: Tuesday, February 7, 2023 4:54 PM
> > > > To: Justin He <Justin.He@arm.com>
> > > > Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org; Alexandru Elisei
> > > > <Alexandru.Elisei@arm.com>; Jason A. Donenfeld <Jason@zx2c4.com>; nd
> > > > <nd@arm.com>
> > > > Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> > > >
> > > > On Tue, 7 Feb 2023 at 09:49, Justin He <Justin.He@arm.com> wrote:
> > > > >
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > [..]
> > > > > > > The root cause of the hung IMO might be similar to commit
> > > > > > > 550b33cfd445296868a478e8413ffb2e963eed32
> > > > > > > Author: Ard Biesheuvel <ardb@kernel.org>
> > > > > > > Date:   Thu Nov 10 10:36:20 2022 +0100
> > > > > > >
> > > > > > >     arm64: efi: Force the use of SetVirtualAddressMap() on
> > > > > > > Altra machines
> > > > > > >
> > > > > > > Do you agree with the idea if I add Ampere ”eMAG” machine into
> > > > > > > the list of Using SetVirtualAddressMap() forcibly?
> > > > > > >
> > > > > > > Please note that even in previous kernel patch, the efibootmgr
> > > > > > > -t
> > > > > > > 10 will make kernel hung if I passed "efi=novamap" to the boot
> > > > parameter.
> > > > > > >
> > > > > >
> > > > > > Interesting. What does dmidecode return for the family in the
> > > > > > type 1
> > > > record?
> > > > >
> > > > > # dmidecode |grep -i family
> > > > >         Family: eMAG
> > > > >         Family: ARMv8
> > > > >
> > > > > The full dmidecode log is at https://pastebin.com/M3MAJtUG
> > > > >
> > > >
> > > > OK please try this:
> > > >
> > > > diff --git a/drivers/firmware/efi/libstub/arm64.c
> > > > b/drivers/firmware/efi/libstub/arm64.c
> > > > index ff2d18c42ee74979..fae930dec82be7c6 100644
> > > > --- a/drivers/firmware/efi/libstub/arm64.c
> > > > +++ b/drivers/firmware/efi/libstub/arm64.c
> > > > @@ -22,7 +22,8 @@ static bool system_needs_vamap(void)
> > > >          * Ampere Altra machines crash in SetTime() if
> > > > SetVirtualAddressMap()
> > > >          * has not been called prior.
> > > >          */
> > > > -       if (!type1_family || strcmp(type1_family, "Altra"))
> > > > +       if (!type1_family ||
> > > > +           (strcmp(type1_family, "Altra") && strcmp(type1_family,
> > > > + "eMAG")))
> > > >                 return false;
> > > >
> > > >         efi_warn("Working around broken SetVirtualAddressMap()\n");
> > >
> > > Yes, it works on my eMAG server: the kernel boots.
> > > Other than efibootmgr failure. But I noticed this efibootmgr failure
> > > even before Commit d3549a938b7 ("avoid SetVirtualAddressMap() when
> > > possible ")
> > >
> > > root@:~/linux# efibootmgr -t 9; efibootmgr -t 5; Could not set
> > > Timeout: Input/output error Could not set Timeout: Input/output error
> > >
> >
> > Do you get any [Firmware Bug] lines in the kernel log?
>
> No,
> I built the kernel based on:
> commit d2d11f342b179f1894a901f143ec7c008caba43e (HEAD -> master, origin/master, origin/HEAD)
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Sun Feb 5 17:17:10 2023 -0800
>
>     Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
>
> Are you worried about your sync exception fixup patch? I think it has been included.
>


I would just like to understand why setvariable is still broken for you.
RE: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
Posted by Justin He 3 years, 2 months ago 
Hi Ard

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Tuesday, February 7, 2023 5:09 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> linux-kernel@vger.kernel.org; Alexandru Elisei <Alexandru.Elisei@arm.com>;
> Jason A. Donenfeld <Jason@zx2c4.com>; nd <nd@arm.com>
> Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> 
> On Tue, 7 Feb 2023 at 10:08, Justin He <Justin.He@arm.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ardb@kernel.org>
> > > Sent: Tuesday, February 7, 2023 5:04 PM
> > > To: Justin He <Justin.He@arm.com>
> > > Cc: Huacai Chen <chenhuacai@kernel.org>; linux-efi@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; Alexandru Elisei
> > > <Alexandru.Elisei@arm.com>; Jason A. Donenfeld <Jason@zx2c4.com>; nd
> > > <nd@arm.com>
> > > Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag server
> > >
> > > On Tue, 7 Feb 2023 at 10:03, Justin He <Justin.He@arm.com> wrote:
> > > >
> > > > Hi Ard
> > > >
> > > > > -----Original Message-----
> > > > > From: Ard Biesheuvel <ardb@kernel.org>
> > > > > Sent: Tuesday, February 7, 2023 4:54 PM
> > > > > To: Justin He <Justin.He@arm.com>
> > > > > Cc: Huacai Chen <chenhuacai@kernel.org>;
> > > > > linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > > > Alexandru Elisei <Alexandru.Elisei@arm.com>; Jason A. Donenfeld
> > > > > <Jason@zx2c4.com>; nd <nd@arm.com>
> > > > > Subject: Re: [PATCH 0/2] Fix boot hang issue on Ampere Emag
> > > > > server
> > > > >
> > > > > On Tue, 7 Feb 2023 at 09:49, Justin He <Justin.He@arm.com> wrote:
> > > > > >
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > [..]
> > > > > > > > The root cause of the hung IMO might be similar to commit
> > > > > > > > 550b33cfd445296868a478e8413ffb2e963eed32
> > > > > > > > Author: Ard Biesheuvel <ardb@kernel.org>
> > > > > > > > Date:   Thu Nov 10 10:36:20 2022 +0100
> > > > > > > >
> > > > > > > >     arm64: efi: Force the use of SetVirtualAddressMap() on
> > > > > > > > Altra machines
> > > > > > > >
> > > > > > > > Do you agree with the idea if I add Ampere ”eMAG” machine
> > > > > > > > into the list of Using SetVirtualAddressMap() forcibly?
> > > > > > > >
> > > > > > > > Please note that even in previous kernel patch, the
> > > > > > > > efibootmgr -t
> > > > > > > > 10 will make kernel hung if I passed "efi=novamap" to the
> > > > > > > > boot
> > > > > parameter.
> > > > > > > >
> > > > > > >
> > > > > > > Interesting. What does dmidecode return for the family in
> > > > > > > the type 1
> > > > > record?
> > > > > >
> > > > > > # dmidecode |grep -i family
> > > > > >         Family: eMAG
> > > > > >         Family: ARMv8
> > > > > >
> > > > > > The full dmidecode log is at https://pastebin.com/M3MAJtUG
> > > > > >
> > > > >
> > > > > OK please try this:
> > > > >
> > > > > diff --git a/drivers/firmware/efi/libstub/arm64.c
> > > > > b/drivers/firmware/efi/libstub/arm64.c
> > > > > index ff2d18c42ee74979..fae930dec82be7c6 100644
> > > > > --- a/drivers/firmware/efi/libstub/arm64.c
> > > > > +++ b/drivers/firmware/efi/libstub/arm64.c
> > > > > @@ -22,7 +22,8 @@ static bool system_needs_vamap(void)
> > > > >          * Ampere Altra machines crash in SetTime() if
> > > > > SetVirtualAddressMap()
> > > > >          * has not been called prior.
> > > > >          */
> > > > > -       if (!type1_family || strcmp(type1_family, "Altra"))
> > > > > +       if (!type1_family ||
> > > > > +           (strcmp(type1_family, "Altra") &&
> > > > > + strcmp(type1_family,
> > > > > + "eMAG")))
> > > > >                 return false;
> > > > >
> > > > >         efi_warn("Working around broken
> > > > > SetVirtualAddressMap()\n");
> > > >
> > > > Yes, it works on my eMAG server: the kernel boots.
> > > > Other than efibootmgr failure. But I noticed this efibootmgr
> > > > failure even before Commit d3549a938b7 ("avoid
> > > > SetVirtualAddressMap() when possible ")
> > > >
> > > > root@:~/linux# efibootmgr -t 9; efibootmgr -t 5; Could not set
> > > > Timeout: Input/output error Could not set Timeout: Input/output
> > > > error
> > > >
> > >
> > > Do you get any [Firmware Bug] lines in the kernel log?
> >
> > No,
> > I built the kernel based on:
> > commit d2d11f342b179f1894a901f143ec7c008caba43e (HEAD -> master,
> > origin/master, origin/HEAD)
> > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > Date:   Sun Feb 5 17:17:10 2023 -0800
> >
> >     Merge branch 'fixes' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
> >
> > Are you worried about your sync exception fixup patch? I think it has been
> included.
> >
> 
> 
> I would just like to understand why setvariable is still broken for you.

On an Ampere *Altra* server, the family name seems to not follow your purpose of invoking efi_get_smbios_string(1, family).

dmidecode |grep -i family -C 10

Handle 0x0001, DMI type 1, 27 bytes
System Information
        Manufacturer: GIGABYTE
        Product Name: R272-P30-00
        Version: 0100
        Serial Number: TS2035812A0022
        UUID: 00000000-0000-4000-8000-B42E99AFEF62
        Wake-up Type: Power Switch
        SKU Number: 01234567890123456789AB
        Family: Server

The full dmidecode info of Altra is at
https://pastebin.com/HQLE1yYv

--
Cheers,
Justin (Jia He)

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.