> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Tuesday, July 8, 2025 12:19 PM > To: Nilawar, Badal <badal.nilawar@intel.com> > Cc: intel-xe@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org; Gupta, Anshuman <anshuman.gupta@intel.com>; > Vivi, Rodrigo <rodrigo.vivi@intel.com>; Usyskin, Alexander > <alexander.usyskin@intel.com>; Ceraolo Spurio, Daniele > <daniele.ceraolospurio@intel.com> > Subject: Re: [PATCH v7 0/9] Introducing firmware late binding > > On Tue, Jul 08, 2025 at 12:42:28AM +0530, Badal Nilawar wrote: > > v7: > > xe_kmd: > > - resolved kernel doc warnings > > mei: > > - Address v6 review comments (greg kh) > > I don't know what comments you addressed, please be specific, as in the past > other ones have not been addressed (i.e. the .owner stuff) and I had to find > that review again... V7 series patch changelog has the details of addressed review comment. https://patchwork.freedesktop.org/patch/662505/?series=151202&rev=3 --- v2: - Use generic naming (Jani) - Drop xe_late_bind_component struct to move to xe code (Daniele/Sasha) v3: - Updated kconfig description - Move CSC late binding specific flags/defines to late_bind_mei_interface.h (Daniele) - Add match for PCI_CLASS_DISPLAY_OTHER to support headless cards (Anshuman) v4: - Add fixes in push_config (Sasha) - Use INTEL_ prefix for component, refine doc, add status enum to headerlate_bind_mei_interface.h (Anshuman) v5: - Addressed review comments v7(greh kh): - dropped sub directory - dropped .owner from late_bind_component_ops - In csc_heci_late_bind_req/rsp headers - used __le32 - updated doc for reserved fields - used conversion macros le32_to_cpu, cpu_to_le32 - fixed duplicate print in dev_dbg --- It seems Latest series[*] after dropping patch 10 does not have details of addressed review comment. * https://patchwork.freedesktop.org/series/151290/ Thanks, Anshuman > > thanks, > > greg k-h
© 2016 - 2025 Red Hat, Inc.