> -----Original Message-----
> From: Julien Panis <jpanis@baylibre.com>
> Sent: Friday, April 12, 2024 7:02 AM
> To: Keller, Jacob E <jacob.e.keller@intel.com>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Russell King
> <linux@armlinux.org.uk>; Alexei Starovoitov <ast@kernel.org>; Daniel Borkmann
> <daniel@iogearbox.net>; Jesper Dangaard Brouer <hawk@kernel.org>; John
> Fastabend <john.fastabend@gmail.com>; Sumit Semwal
> <sumit.semwal@linaro.org>; Christian König <christian.koenig@amd.com>; Simon
> Horman <horms@kernel.org>; Andrew Lunn <andrew@lunn.ch>; Ratheesh
> Kannoth <rkannoth@marvell.com>; Naveen Mamindlapalli
> <naveenm@marvell.com>
> Cc: danishanwar@ti.com; yuehaibing@huawei.com; rogerq@kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; bpf@vger.kernel.org; linux-
> media@vger.kernel.org; dri-devel@lists.freedesktop.org; linaro-mm-
> sig@lists.linaro.org
> Subject: Re: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW
> Ethernet driver
> 
> On 4/10/24 01:51, Jacob Keller wrote:
> >
> > On 4/8/2024 2:38 AM, Julien Panis wrote:
> >> This patch adds XDP support to TI AM65 CPSW Ethernet driver.
> >>
> >> The following features are implemented: NETDEV_XDP_ACT_BASIC,
> >> NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT.
> >>
> >> Zero-copy and non-linear XDP buffer supports are NOT implemented.
> >>
> >> Besides, the page pool memory model is used to get better performance.
> >>
> >> Signed-off-by: Julien Panis <jpanis@baylibre.com>
> >> ---
> > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> 
> Thank you for your review Jacob.
> I'll add your 'Reviewed-by' tag for PATCH 1/3 in next version. Unfortunately,
> I will not for PATCH 2/3 and 3/3 because there will be too many changes,
> following Jakub's comments.

Sounds good. Feel free to CC me on the next version too and I can review the new changes 😊