RE: [PATCH v2 0/3] mtd: spi-nor: winbond: Fix protection handling

Posted by Farber, Eliav 1 month, 1 week ago

> > Changes in v2:
> > - Remove last patch in series that added dual/quad read for w25q64jvm
>
> Why? Unfortunately, you didn't answer my questions.

The SFDP dump I added indicates that both dual-read and quad-read modes
are supported.

> > - Added Minimum testing requirements for w25q256jwm and w25q64jvm
>
> Thanks, but why was the w25q256jw left out?

I still haven’t been able to get a card with w25q256jw.
Is it needed in order to add the lock flags?

---
Regards, Eliav

Re: [PATCH v2 0/3] mtd: spi-nor: winbond: Fix protection handling

Posted by Michael Walle 1 month, 1 week ago

On Thu Feb 19, 2026 at 9:59 AM CET, Eliav Farber wrote:
>> > Changes in v2:
>> > - Remove last patch in series that added dual/quad read for w25q64jvm
>>
>> Why? Unfortunately, you didn't answer my questions.
>
> The SFDP dump I added indicates that both dual-read and quad-read modes
> are supported.

That was already the case for your initial submission. So what has
changed?

If you're a bit more verbose in the changelog, that would make
things much easier for us reviewers. 

>> > - Added Minimum testing requirements for w25q256jwm and w25q64jvm
>>
>> Thanks, but why was the w25q256jw left out?
>
> I still haven’t been able to get a card with w25q256jw.
> Is it needed in order to add the lock flags?

Not from my side, other maintainers may disagree. I'm more
interested in the SFDP dump. In any case, you already have my
Reviewed-by.

-michael