mtd: rawnand: r852: [PATCH] Fixed a spelling error in the comments

Posted by Terence Eden 10 months ago

Continuing the work of Commit #8ab1b51 /
https://lore.kernel.org/linux-mtd/20240923065649.11966-1-shenlichuan@vivo.com/

This fixes a spelling error in the comments and removes an errant newline.

Signed-off-by: Terence Eden <terence.eden@shkspr.mobi>
---
 drivers/mtd/nand/raw/r852.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/r852.c b/drivers/mtd/nand/raw/r852.c
index b07c2f8b4035..136589f9a0e9 100644
--- a/drivers/mtd/nand/raw/r852.c
+++ b/drivers/mtd/nand/raw/r852.c
@@ -242,13 +242,12 @@ static void r852_write_buf(struct nand_chip
*chip, const uint8_t *buf, int len)
                return;
        }

-       /* write DWORD chinks - faster */
+       /* write DWORD chunks - faster */
        while (len >= 4) {
                reg = buf[0] | buf[1] << 8 | buf[2] << 16 | buf[3] << 24;
                r852_write_reg_dword(dev, R852_DATALINE, reg);
                buf += 4;
                len -= 4;
-
        }

        /* write rest */
-- 
2.34.1

On Tue, 18 Feb 2025 at 13:58, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hello,
>
> On 18/02/2025 at 13:21:42 GMT, Terence Eden <terence.eden@shkspr.mobi> wrote:
>
> > Continuing the work of Commit #8ab1b51 /
> > https://lore.kernel.org/linux-mtd/20240923065649.11966-1-shenlichuan@vivo.com/
>
> While the diff is obviously fine, I'd prefer if you could write a proper
> commit log.
>
> Also the title should be prefixed "mtd: rawnand: r852: "
>
> Thanks,
> Miquèl

Re: mtd: rawnand: r852: [PATCH] Fixed a spelling error in the comments

Posted by Miquel Raynal 10 months ago

Hello Terence,

On 19/02/2025 at 11:59:10 GMT, Terence Eden <terence.eden@shkspr.mobi> wrote:

> Continuing the work of Commit #8ab1b51 /
> https://lore.kernel.org/linux-mtd/20240923065649.11966-1-shenlichuan@vivo.com/
>
> This fixes a spelling error in the comments and removes an errant newline.
>
> Signed-off-by: Terence Eden <terence.eden@shkspr.mobi>

I'm sorry but the formatting is still wrong:
- Your commit title should be "mtd: rawnand: r852: Fix a spelling error in the comments"
- I recommend you use git-format-patch or b4 to format your patches,
  which will prefix [PATCH] automatically.
- You need to increase the version when you send an iteration, this is
  v2, next will be v3 and this must be also done automatically by the
  tools, the final result should look like "[PATCH vX]".
- When sending a new iteration you need to give a changelog, and do that
outside of the commit log, ie...

> ---

  ^^^
Below these '---'

Thanks,
Miquèl