From 6bc4478708261b77cd9eea568a4de8f60ce5cd7c Mon Sep 17 00:00:00 2001
From: Haribytecode <osdevhari@gmail.com>
Date: Sat, 18 Apr 2026 08:54:59 +0530
Subject: [PATCH] staging: rtl8723bs: remove trailing whitespace in
rtw_xmit.c

Fix checkpatch error for trailing whitespace.

Signed-off-by: Haribytecode <osdevhari@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index d77a2f3603ae..4cedb6a06f45 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2176,13 +2176,12 @@ static void
dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter, struc

  ret = xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe);

- if (true == ret) {
+ if (ret) {
  ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8
*)(&ac_index));

  ptxservq->qcnt--;
  phwxmits[ac_index].accnt--;
- } else {
- }
+ }
  }
 }

-- 
2.53.0

Hi Osdevhari,
Let's start from the top of the email. Firstly attachments are not 
allowed, only plaintext. Secondly Signed-off-by tag must use your real
name(Firstname Lastname <email>. Thirdly, you should setup git 
send-email and use it to send patches. Now let's take a look at actual
code:

>ret = xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe);

>- if (true == ret) {
>+ if (ret) {
Here you did completely unrelated change to what your commit says.
>  ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8
>*)(&ac_index));
Also why break this line.
>
>  ptxservq->qcnt--;
>  phwxmits[ac_index].accnt--;
>- } else {
>- }
>+ }
>  }
 Here you removed an else without readding it
> }

You didn't even do anything related to trailing whitespace, they 
weren't even there. Also please don't do unrelated changes and stick 
to atomic patch rule. Check Documentation/process for more 
information on how to create and send patches.
Best regards,
Luka Gejak

On Sat, Apr 18, 2026 at 09:10:47AM +0200, Luka Gejak wrote:
> Hi Osdevhari,
> Let's start from the top of the email. Firstly attachments are not 
> allowed, only plaintext. Secondly Signed-off-by tag must use your real
> name(Firstname Lastname <email>. Thirdly, you should setup git 
> send-email and use it to send patches. Now let's take a look at actual
> code:

Again, Luka, please take a break from reviews.  I would recommend
getting some more experience in the developer workflow before doing
this, as it can be a bit confusing for new developers coming in to see
stuff like this.

And again, please do not use AI for reviews, we have that already, and
there is a big reason I do not let it loose on the staging list because
it is not yet ready for it.

thanks,

greg k-h

On April 18, 2026 9:24:01 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Sat, Apr 18, 2026 at 09:10:47AM +0200, Luka Gejak wrote:
>> Hi Osdevhari,
>> Let's start from the top of the email. Firstly attachments are not 
>> allowed, only plaintext. Secondly Signed-off-by tag must use your real
>> name(Firstname Lastname <email>. Thirdly, you should setup git 
>> send-email and use it to send patches. Now let's take a look at actual
>> code:
>
>Again, Luka, please take a break from reviews.  I would recommend
>getting some more experience in the developer workflow before doing
>this, as it can be a bit confusing for new developers coming in to see
>stuff like this.
>
>And again, please do not use AI for reviews, we have that already, and
>there is a big reason I do not let it loose on the staging list because
>it is not yet ready for it.
>
>thanks,
>
>greg k-h

Please check my response to your other email and feel free to plug my 
responses into ai detector if that will prove it is not ai(I tested it
returned human).
Best regards,
Luka Gejak

On Sat, Apr 18, 2026 at 09:37:40AM +0200, Luka Gejak wrote:
> On April 18, 2026 9:24:01 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Sat, Apr 18, 2026 at 09:10:47AM +0200, Luka Gejak wrote:
> >> Hi Osdevhari,
> >> Let's start from the top of the email. Firstly attachments are not 
> >> allowed, only plaintext. Secondly Signed-off-by tag must use your real
> >> name(Firstname Lastname <email>. Thirdly, you should setup git 
> >> send-email and use it to send patches. Now let's take a look at actual
> >> code:
> >
> >Again, Luka, please take a break from reviews.  I would recommend
> >getting some more experience in the developer workflow before doing
> >this, as it can be a bit confusing for new developers coming in to see
> >stuff like this.
> >
> >And again, please do not use AI for reviews, we have that already, and
> >there is a big reason I do not let it loose on the staging list because
> >it is not yet ready for it.
> >
> >thanks,
> >
> >greg k-h
> 
> Please check my response to your other email and feel free to plug my 
> responses into ai detector if that will prove it is not ai(I tested it
> returned human).

"ai detectors" are worth the value that you paid for them (i.e.
nothing...)

thanks,

greg k-h

On April 18, 2026 9:10:47 AM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
>Hi Osdevhari,
>Let's start from the top of the email. Firstly attachments are not 
>allowed, only plaintext. Secondly Signed-off-by tag must use your real
>name(Firstname Lastname <email>. Thirdly, you should setup git 
>send-email and use it to send patches. Now let's take a look at actual
>code:
>
>>ret = xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe);
>
>>- if (true == ret) {
>>+ if (ret) {
>Here you did completely unrelated change to what your commit says.
>>  ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8
>>*)(&ac_index));
>Also why break this line.
>>
>>  ptxservq->qcnt--;
>>  phwxmits[ac_index].accnt--;
>>- } else {
>>- }
>>+ }
>>  }
> Here you removed an else without readding it
>> }
>
>You didn't even do anything related to trailing whitespace, they 
>weren't even there. Also please don't do unrelated changes and stick 
>to atomic patch rule. Check Documentation/process for more 
>information on how to create and send patches.
>Best regards,
>Luka Gejak

Hi Osdevhari,
Let me add two more things: Your patch actually introduced trailing 
whitespace:

git am patch.mbx
Applying: staging: rtl8723bs: remove trailing whitespace in rtw_xmit.c
.git/rebase-apply/patch:21: trailing whitespace.
                }
warning: 1 line adds whitespace errors.

>Fix checkpatch error for trailing whitespace.
And trailing whitespace is a warning not an error.
Best regards,
Luka Gejak