[PATCH] ocfs2: o2net_idle_timer: Rename del_timer_sync in comment

WangYuli posted 1 patch 10 months ago
fs/ocfs2/cluster/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ocfs2: o2net_idle_timer: Rename del_timer_sync in comment
Posted by WangYuli 10 months ago
Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
switched del_timer_sync to timer_delete_sync, but did not modify the
comment for o2net_idle_timer(). Now fix it.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 fs/ocfs2/cluster/tcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
index fce9beb214f0..43e652a2adaf 100644
--- a/fs/ocfs2/cluster/tcp.c
+++ b/fs/ocfs2/cluster/tcp.c
@@ -1483,7 +1483,7 @@ static void o2net_sc_send_keep_req(struct work_struct *work)
 	sc_put(sc);
 }
 
-/* socket shutdown does a del_timer_sync against this as it tears down.
+/* socket shutdown does a timer_delete_sync against this as it tears down.
  * we can't start this timer until we've got to the point in sc buildup
  * where shutdown is going to be involved */
 static void o2net_idle_timer(struct timer_list *t)
-- 
2.49.0
Re: [PATCH] ocfs2: o2net_idle_timer: Rename del_timer_sync in comment
Posted by Joseph Qi 10 months ago

On 2025/4/11 18:26, WangYuli wrote:
> Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
> switched del_timer_sync to timer_delete_sync, but did not modify the
> comment for o2net_idle_timer(). Now fix it.
> 
> Signed-off-by: WangYuli <wangyuli@uniontech.com>

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/cluster/tcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
> index fce9beb214f0..43e652a2adaf 100644
> --- a/fs/ocfs2/cluster/tcp.c
> +++ b/fs/ocfs2/cluster/tcp.c
> @@ -1483,7 +1483,7 @@ static void o2net_sc_send_keep_req(struct work_struct *work)
>  	sc_put(sc);
>  }
>  
> -/* socket shutdown does a del_timer_sync against this as it tears down.
> +/* socket shutdown does a timer_delete_sync against this as it tears down.
>   * we can't start this timer until we've got to the point in sc buildup
>   * where shutdown is going to be involved */
>  static void o2net_idle_timer(struct timer_list *t)