[PATCH v2 4/8] net: mvneta: Fix typo "notifer"

WangYuli posted 8 patches 2 months, 3 weeks ago
There is a newer version of this series
[PATCH v2 4/8] net: mvneta: Fix typo "notifer"
Posted by WangYuli 2 months, 3 weeks ago
There is a spelling mistake of 'notifer' in the comment which
should be 'notifier'.

Link: https://lore.kernel.org/all/B3C019B63C93846F+20250715071245.398846-1-wangyuli@uniontech.com/
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 drivers/net/ethernet/marvell/mvneta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 147571fdada3..ee4696600146 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -4610,7 +4610,7 @@ static int mvneta_stop(struct net_device *dev)
 		/* Inform that we are stopping so we don't want to setup the
 		 * driver for new CPUs in the notifiers. The code of the
 		 * notifier for CPU online is protected by the same spinlock,
-		 * so when we get the lock, the notifer work is done.
+		 * so when we get the lock, the notifier work is done.
 		 */
 		spin_lock(&pp->lock);
 		pp->is_stopped = true;
-- 
2.50.0
Re: [PATCH v2 4/8] net: mvneta: Fix typo "notifer"
Posted by Simon Horman 2 months, 3 weeks ago
On Tue, Jul 15, 2025 at 09:44:03PM +0800, WangYuli wrote:
> There is a spelling mistake of 'notifer' in the comment which
> should be 'notifier'.
> 
> Link: https://lore.kernel.org/all/B3C019B63C93846F+20250715071245.398846-1-wangyuli@uniontech.com/

As suggested by Jonathan Cameron elsewhere in this thread, this link to an
earlier version doesn't seem appropriate here. I'd suggest it belongs
below the scissors ('---') with a note that it is a link to v1.

> Signed-off-by: WangYuli <wangyuli@uniontech.com>

The comment above notwithstanding this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>