[PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"

WangYuli posted 8 patches 2 months, 3 weeks ago
There is a newer version of this series
[PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"
Posted by WangYuli 2 months, 3 weeks ago
There is a spelling mistake of 'notifer' in the comment which
should be 'notifier'.

Link: https://lore.kernel.org/all/B3C019B63C93846F+20250715071245.398846-1-wangyuli@uniontech.com/
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 drivers/tty/serial/8250/8250_dw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 1902f29444a1..6d9af6417620 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -392,7 +392,7 @@ static void dw8250_set_termios(struct uart_port *p, struct ktermios *termios,
 	rate = clk_round_rate(d->clk, newrate);
 	if (rate > 0) {
 		/*
-		 * Note that any clock-notifer worker will block in
+		 * Note that any clock-notifier worker will block in
 		 * serial8250_update_uartclk() until we are done.
 		 */
 		ret = clk_set_rate(d->clk, newrate);
-- 
2.50.0
Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"
Posted by Greg KH 2 months, 3 weeks ago
On Tue, Jul 15, 2025 at 09:44:05PM +0800, WangYuli wrote:
> There is a spelling mistake of 'notifer' in the comment which
> should be 'notifier'.
> 
> Link: https://lore.kernel.org/all/B3C019B63C93846F+20250715071245.398846-1-wangyuli@uniontech.com/
> Signed-off-by: WangYuli <wangyuli@uniontech.com>

Is your name all one word like that, or should there be a " " between
them?

Also, as others said, don't link to your own patch.

thanks,

greg k-h
Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"
Posted by WangYuli 2 months, 2 weeks ago
Hi greg k-h,

On 2025/7/16 16:08, Greg KH wrote:
>> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> Is your name all one word like that, or should there be a " " between
> them?

If I were to follow Western naming conventions, my name would be written 
as 'Yuli Wang'.

However, frankly, I find it unnecessary and can't be bothered to follow 
their customs, unless a maintainer strongly insists. (For example, you 
can see that my signature on commits for the LoongArch subsystem is 
different from my other contributions).

Since Chinese names are written without any spaces in Chinese 
characters, I don't think it matters.

> Also, as others said, don't link to your own patch.
OK, I'll send the patchset v3.


Thanks,

-- 
王昱力
Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"
Posted by Greg KH 2 months, 2 weeks ago
On Tue, Jul 22, 2025 at 03:22:18PM +0800, WangYuli wrote:
> Hi greg k-h,
> 
> On 2025/7/16 16:08, Greg KH wrote:
> > > Signed-off-by: WangYuli <wangyuli@uniontech.com>
> > Is your name all one word like that, or should there be a " " between
> > them?
> 
> If I were to follow Western naming conventions, my name would be written as
> 'Yuli Wang'.
> 
> However, frankly, I find it unnecessary and can't be bothered to follow
> their customs, unless a maintainer strongly insists. (For example, you can
> see that my signature on commits for the LoongArch subsystem is different
> from my other contributions).
> 
> Since Chinese names are written without any spaces in Chinese characters, I
> don't think it matters.

Then use your Chinese name, don't feel like you need to change it to any
other naming convention.  There's no requirement here at all to do so.

thanks,

greg k-h
Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"
Posted by H. Peter Anvin 2 months, 2 weeks ago
On July 22, 2025 12:57:33 AM PDT, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Tue, Jul 22, 2025 at 03:22:18PM +0800, WangYuli wrote:
>> Hi greg k-h,
>> 
>> On 2025/7/16 16:08, Greg KH wrote:
>> > > Signed-off-by: WangYuli <wangyuli@uniontech.com>
>> > Is your name all one word like that, or should there be a " " between
>> > them?
>> 
>> If I were to follow Western naming conventions, my name would be written as
>> 'Yuli Wang'.
>> 
>> However, frankly, I find it unnecessary and can't be bothered to follow
>> their customs, unless a maintainer strongly insists. (For example, you can
>> see that my signature on commits for the LoongArch subsystem is different
>> from my other contributions).
>> 
>> Since Chinese names are written without any spaces in Chinese characters, I
>> don't think it matters.
>
>Then use your Chinese name, don't feel like you need to change it to any
>other naming convention.  There's no requirement here at all to do so.
>
>thanks,
>
>greg k-h

To put it differently: what Greg (and the rest of us) want to make sure is that your name appears the way you prefer. 

Having the Latin transliteration in whatever form you prefer is greatly appreciated, of course, since the knowledge of Chinese script is limited outside East Asia, but that's just about it.

If you want to add your name in proper Chinese script in addition that should be fine, too.
Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"
Posted by Andy Shevchenko 2 months, 3 weeks ago
On Tue, Jul 15, 2025 at 09:44:05PM +0800, WangYuli wrote:
> There is a spelling mistake of 'notifer' in the comment which
> should be 'notifier'.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko