[PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc

Christophe JAILLET posted 1 patch 1 year, 10 months ago
drivers/clk/qcom/clk-rpm.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc
Posted by Christophe JAILLET 1 year, 10 months ago
In "struct rpm_cc", the 'rpm' field is unused.

Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.

Apparently, it has never been used. It is not a left-over from a
refactoring.
---
 drivers/clk/qcom/clk-rpm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
index 745026ef4d9c..9da034f8f2ff 100644
--- a/drivers/clk/qcom/clk-rpm.c
+++ b/drivers/clk/qcom/clk-rpm.c
@@ -98,7 +98,6 @@ struct clk_rpm {
 };
 
 struct rpm_cc {
-	struct qcom_rpm *rpm;
 	struct clk_rpm **clks;
 	size_t num_clks;
 	u32 xo_buffer_value;
-- 
2.44.0
Re: [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc
Posted by Bjorn Andersson 1 year, 9 months ago
On Sat, 13 Apr 2024 16:04:04 +0200, Christophe JAILLET wrote:
> In "struct rpm_cc", the 'rpm' field is unused.
> 
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: rpm: Remove an unused field in struct rpm_cc
      commit: 3cb55215479f04940240792479c60fad53c2d202

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc
Posted by Stephen Boyd 1 year, 9 months ago
Quoting Christophe JAILLET (2024-04-13 07:04:04)
> In "struct rpm_cc", the 'rpm' field is unused.
> 
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>