This doesn't affect how the code works because there are some implicit
casts, but the "ret" variable is used to hold negative error codes so
it should be type int.

Declare it as "int" instead of "unsigned int".

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/mfd/cgbc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
index 85283c8dde25..0b3788c2c1af 100644
--- a/drivers/mfd/cgbc-core.c
+++ b/drivers/mfd/cgbc-core.c
@@ -96,7 +96,7 @@ static int cgbc_session_command(struct cgbc_device_data *cgbc, u8 cmd)
 
 static int cgbc_session_request(struct cgbc_device_data *cgbc)
 {
-	unsigned int ret;
+	int ret;
 
 	ret = cgbc_wait_device(cgbc);
 
-- 
2.47.2

On Wed, 12 Mar 2025 11:34:50 +0300, Dan Carpenter wrote:
> This doesn't affect how the code works because there are some implicit
> casts, but the "ret" variable is used to hold negative error codes so
> it should be type int.
> 
> Declare it as "int" instead of "unsigned int".
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: cgbc-core: cleanup signedness in cgbc_session_request()
      commit: 3ce71a089364813c5ca953d7bf527b6ba477d5da

--
Lee Jones [李琼斯]