[PATCH] thermal/core/power allocator: Remove a useless include

Christophe JAILLET posted 1 patch 2 years, 9 months ago
drivers/thermal/gov_power_allocator.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] thermal/core/power allocator: Remove a useless include
Posted by Christophe JAILLET 2 years, 9 months ago
This file does not use rcu, so there is no point in including
<linux/rculist.h>.

Remove it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/thermal/gov_power_allocator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 2d1aeaba38a8..d5d4eae16771 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -8,7 +8,6 @@
 
 #define pr_fmt(fmt) "Power allocator: " fmt
 
-#include <linux/rculist.h>
 #include <linux/slab.h>
 #include <linux/thermal.h>
 
-- 
2.34.1
Re: [PATCH] thermal/core/power allocator: Remove a useless include
Posted by Daniel Lezcano 2 years, 9 months ago
On 26/11/2022 11:42, Christophe JAILLET wrote:
> This file does not use rcu, so there is no point in including
> <linux/rculist.h>.
> 
> Remove it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] thermal/core/power allocator: Remove a useless include
Posted by Lukasz Luba 2 years, 9 months ago

On 11/26/22 10:42, Christophe JAILLET wrote:
> This file does not use rcu, so there is no point in including
> <linux/rculist.h>.
> 
> Remove it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/thermal/gov_power_allocator.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index 2d1aeaba38a8..d5d4eae16771 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -8,7 +8,6 @@
>   
>   #define pr_fmt(fmt) "Power allocator: " fmt
>   
> -#include <linux/rculist.h>
>   #include <linux/slab.h>
>   #include <linux/thermal.h>
>   

Good catch.

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>