init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV_INITRD

[PATCH] init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV_INITRD

Posted by Geert Uytterhoeven 2 weeks, 3 days ago

INITRAMFS_PRESERVE_MTIME is only used in init/initramfs.c and
init/initramfs_test.c.  Hence add a dependency on BLK_DEV_INITRD, to
prevent asking the user about this feature when configuring a kernel
without initramfs support.

Fixes: 1274aea127b2e8c9 ("initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 init/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/Kconfig b/init/Kconfig
index e3eb63eadc8757a1..c0c61206499e6bd5 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1501,6 +1501,7 @@ config BOOT_CONFIG_EMBED_FILE
 
 config INITRAMFS_PRESERVE_MTIME
 	bool "Preserve cpio archive mtimes in initramfs"
+	depends on BLK_DEV_INITRD
 	default y
 	help
 	  Each entry in an initramfs cpio archive carries an mtime value. When
-- 
2.43.0

Re: [PATCH] init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV_INITRD

Posted by Christian Brauner 2 weeks, 3 days ago

On Mon, 15 Sep 2025 09:11:05 +0200, Geert Uytterhoeven wrote:
> INITRAMFS_PRESERVE_MTIME is only used in init/initramfs.c and
> init/initramfs_test.c.  Hence add a dependency on BLK_DEV_INITRD, to
> prevent asking the user about this feature when configuring a kernel
> without initramfs support.
> 
> 

Applied to the vfs-6.18.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.18.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.18.misc

[1/1] init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV_INITRD
      https://git.kernel.org/vfs/vfs/c/74792608606a

Re: [PATCH] init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV_INITRD

Posted by Martin Wilck 2 weeks, 3 days ago

On Mon, 2025-09-15 at 09:11 +0200, Geert Uytterhoeven wrote:
> INITRAMFS_PRESERVE_MTIME is only used in init/initramfs.c and
> init/initramfs_test.c.  Hence add a dependency on BLK_DEV_INITRD, to
> prevent asking the user about this feature when configuring a kernel
> without initramfs support.
> 
> Fixes: 1274aea127b2e8c9 ("initramfs: add INITRAMFS_PRESERVE_MTIME
> Kconfig option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Martin  Wilck <mwilck@suse.com>

> ---
>  init/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index e3eb63eadc8757a1..c0c61206499e6bd5 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1501,6 +1501,7 @@ config BOOT_CONFIG_EMBED_FILE
>  
>  config INITRAMFS_PRESERVE_MTIME
>  	bool "Preserve cpio archive mtimes in initramfs"
> +	depends on BLK_DEV_INITRD
>  	default y
>  	help
>  	  Each entry in an initramfs cpio archive carries an mtime
> value. When

Re: [PATCH] init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV_INITRD

Posted by David Disseldorp 2 weeks, 3 days ago

On Mon, 15 Sep 2025 09:11:05 +0200, Geert Uytterhoeven wrote:

> INITRAMFS_PRESERVE_MTIME is only used in init/initramfs.c and
> init/initramfs_test.c.  Hence add a dependency on BLK_DEV_INITRD, to
> prevent asking the user about this feature when configuring a kernel
> without initramfs support.
> 
> Fixes: 1274aea127b2e8c9 ("initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Makes sense, thanks.

Reviewed-by: David Disseldorp <ddiss@suse.de>