xfs: Simplify data output in xfs_zoned_show_stats()

[PATCH] xfs: Simplify data output in xfs_zoned_show_stats()

Posted by Markus Elfring 3 days, 23 hours ago

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 4 Jun 2026 11:16:01 +0200

Move the specification for a line break from a seq_puts() call
to a seq_printf() call.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 fs/xfs/xfs_zone_info.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_zone_info.c b/fs/xfs/xfs_zone_info.c
index 47b475e21af8..57e3acabeee4 100644
--- a/fs/xfs/xfs_zone_info.c
+++ b/fs/xfs/xfs_zone_info.c
@@ -75,10 +75,8 @@ xfs_zoned_show_stats(
 	struct xfs_zone_info	*zi = mp->m_zone_info;
 	struct xfs_open_zone	*oz;
 
-	seq_puts(m, "\n");
-
-	seq_printf(m, "\tuser free RT blocks: %lld\n",
-		xfs_sum_freecounter(mp, XC_FREE_RTEXTENTS));
+	seq_printf(m, "\n\tuser free RT blocks: %lld\n",
+		   xfs_sum_freecounter(mp, XC_FREE_RTEXTENTS));
 	seq_printf(m, "\treserved free RT blocks: %lld\n",
 		mp->m_free[XC_FREE_RTEXTENTS].res_avail);
 	seq_printf(m, "\tuser available RT blocks: %lld\n",
-- 
2.54.0

Re: [PATCH] xfs: Simplify data output in xfs_zoned_show_stats()

Posted by Christoph Hellwig 3 days ago

On Thu, Jun 04, 2026 at 11:20:55AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 4 Jun 2026 11:16:01 +0200
> 
> Move the specification for a line break from a seq_puts() call
> to a seq_printf() call.

Umm, no.  Make the code much less redable for no real benefit.

Re: [PATCH] xfs: Simplify data output in xfs_zoned_show_stats()

Posted by Markus Elfring 2 days, 20 hours ago

>> Move the specification for a line break from a seq_puts() call
>> to a seq_printf() call.
> 
> Umm, no.  Make the code much less redable for no real benefit.
Would you prefer to use a seq_putc() call instead at such a source code place?
https://elixir.bootlin.com/linux/v7.1-rc6/source/fs/xfs/xfs_zone_info.c#L78

Regards,
Markus