[v1] firmware: imx: IMX_SCMI_MISC_DRV should depend on ARCH_MXC

[PATCH resend] firmware: imx: IMX_SCMI_MISC_DRV should depend on ARCH_MXC

Posted by Geert Uytterhoeven 10 months, 1 week ago

The i.MX System Controller Management Interface firmware is only present
on Freescale i.MX SoCs.  Hence add a dependency on ARCH_MXC, to prevent
asking the user about this driver when configuring a kernel without
Freescale i.MX platform support.

Fixes: 514b2262ade48a05 ("firmware: arm_scmi: Fix i.MX build dependency")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/firmware/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig
index 907cd149c40a8b5f..c964f4924359fcd3 100644
--- a/drivers/firmware/imx/Kconfig
+++ b/drivers/firmware/imx/Kconfig
@@ -25,6 +25,7 @@ config IMX_SCU
 
 config IMX_SCMI_MISC_DRV
 	tristate "IMX SCMI MISC Protocol driver"
+	depends on ARCH_MXC || COMPILE_TEST
 	default y if ARCH_MXC
 	help
 	  The System Controller Management Interface firmware (SCMI FW) is
-- 
2.43.0

Re: [PATCH resend] firmware: imx: IMX_SCMI_MISC_DRV should depend on ARCH_MXC

Posted by Shawn Guo 9 months, 3 weeks ago

On Wed, Feb 05, 2025 at 03:41:43PM +0100, Geert Uytterhoeven wrote:
> The i.MX System Controller Management Interface firmware is only present
> on Freescale i.MX SoCs.  Hence add a dependency on ARCH_MXC, to prevent
> asking the user about this driver when configuring a kernel without
> Freescale i.MX platform support.
> 
> Fixes: 514b2262ade48a05 ("firmware: arm_scmi: Fix i.MX build dependency")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for the patch, Geert!  But I have just picked up the change from
Uwe [1].

Shawn

[1] https://lore.kernel.org/imx/20250204101531.233549-2-u.kleine-koenig@baylibre.com/

Re: [PATCH resend] firmware: imx: IMX_SCMI_MISC_DRV should depend on ARCH_MXC

Posted by Geert Uytterhoeven 9 months, 3 weeks ago

Hi Shawn,

On Sun, 23 Feb 2025 at 08:21, Shawn Guo <shawnguo2@yeah.net> wrote:
> On Wed, Feb 05, 2025 at 03:41:43PM +0100, Geert Uytterhoeven wrote:
> > The i.MX System Controller Management Interface firmware is only present
> > on Freescale i.MX SoCs.  Hence add a dependency on ARCH_MXC, to prevent
> > asking the user about this driver when configuring a kernel without
> > Freescale i.MX platform support.
> >
> > Fixes: 514b2262ade48a05 ("firmware: arm_scmi: Fix i.MX build dependency")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks for the patch, Geert!  But I have just picked up the change from
> Uwe [1].

Thanks, but mine has been upstream since Friday ;-)

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be6686b823b30a69b1f71bde228ce042c78a1941

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH resend] firmware: imx: IMX_SCMI_MISC_DRV should depend on ARCH_MXC

Posted by Shawn Guo 9 months, 3 weeks ago

+ Uwe

On Sun, Feb 23, 2025 at 09:29:29AM +0100, Geert Uytterhoeven wrote:
> Hi Shawn,
> 
> On Sun, 23 Feb 2025 at 08:21, Shawn Guo <shawnguo2@yeah.net> wrote:
> > On Wed, Feb 05, 2025 at 03:41:43PM +0100, Geert Uytterhoeven wrote:
> > > The i.MX System Controller Management Interface firmware is only present
> > > on Freescale i.MX SoCs.  Hence add a dependency on ARCH_MXC, to prevent
> > > asking the user about this driver when configuring a kernel without
> > > Freescale i.MX platform support.
> > >
> > > Fixes: 514b2262ade48a05 ("firmware: arm_scmi: Fix i.MX build dependency")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Thanks for the patch, Geert!  But I have just picked up the change from
> > Uwe [1].
> 
> Thanks, but mine has been upstream since Friday ;-)
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be6686b823b30a69b1f71bde228ce042c78a1941

Ah, Arnd beat me to it.  Thanks for information!

Shawn

Re: [PATCH resend] firmware: imx: IMX_SCMI_MISC_DRV should depend on ARCH_MXC

Posted by Fabio Estevam 10 months, 1 week ago

On Wed, Feb 5, 2025 at 11:52 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The i.MX System Controller Management Interface firmware is only present
> on Freescale i.MX SoCs.  Hence add a dependency on ARCH_MXC, to prevent
> asking the user about this driver when configuring a kernel without
> Freescale i.MX platform support.
>
> Fixes: 514b2262ade48a05 ("firmware: arm_scmi: Fix i.MX build dependency")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Fabio Estevam <festevam@gmail.com>