ext4: cleanup variable name in ext4_fc_del()

[PATCH] ext4: cleanup variable name in ext4_fc_del()

Posted by Dan Carpenter 1 month, 2 weeks ago

The variables "&EXT4_SB(inode->i_sb)->s_fc_lock" and "&sbi->s_fc_lock"
are the same lock.  This function uses a mix of both, which is a bit
unsightly and confuses Smatch.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 fs/ext4/fast_commit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index b33664f6ce2a..e4cb1356e9b6 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -291,9 +291,9 @@ void ext4_fc_del(struct inode *inode)
 		return;
 
 restart:
-	spin_lock(&EXT4_SB(inode->i_sb)->s_fc_lock);
+	spin_lock(&sbi->s_fc_lock);
 	if (list_empty(&ei->i_fc_list) && list_empty(&ei->i_fc_dilist)) {
-		spin_unlock(&EXT4_SB(inode->i_sb)->s_fc_lock);
+		spin_unlock(&sbi->s_fc_lock);
 		return;
 	}
 
-- 
2.45.2

Re: [PATCH] ext4: cleanup variable name in ext4_fc_del()

Posted by Theodore Ts'o 1 week, 5 days ago

On Fri, 11 Oct 2024 22:43:44 +0300, Dan Carpenter wrote:
> The variables "&EXT4_SB(inode->i_sb)->s_fc_lock" and "&sbi->s_fc_lock"
> are the same lock.  This function uses a mix of both, which is a bit
> unsightly and confuses Smatch.
> 
> 

Applied, thanks!

[1/1] ext4: cleanup variable name in ext4_fc_del()
      commit: 27349b4d2ed072cabedd5115f0542b3b7b538aa8

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>