[PATCH] Makefile: Remove the product of pin_init cleanly in mrporper

chenmiao posted 1 patch 3 months, 1 week ago
There is a newer version of this series
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Makefile: Remove the product of pin_init cleanly in mrporper
Posted by chenmiao 3 months, 1 week ago
When I enabled Rust compilation, I wanted to clean up its output, so I
used make clean and make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

If this is an intentional design, I will drop this commit.

Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: chenmiao <chenmiao@openatom.club>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b34a1f4c03967..f43a70413a6aa 100644
--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,7 @@ MRPROPER_FILES += include/config include/generated          \
 		  certs/x509.genkey \
 		  vmlinux-gdb.py \
 		  rpmbuild \
-		  rust/libmacros.so rust/libmacros.dylib
+		  rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so
 
 # clean - Delete most, but leave enough to build external modules
 #
-- 
2.43.0
Re: [PATCH] Makefile: Remove the product of pin_init cleanly in mrporper
Posted by Miguel Ojeda 3 months, 1 week ago
On Thu, Oct 30, 2025 at 10:08 AM chenmiao <chenmiao@openatom.club> wrote:
>
> -                 rust/libmacros.so rust/libmacros.dylib
> +                 rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so

I think we will need the `.dylib` too, given the other one is there
(for the macOS builds some people do -- Cc'ing Daniel and Tamir). Or
did you avoid it for some reason?

Thanks!

Cheers,
Miguel
Re: [PATCH] Makefile: Remove the product of pin_init cleanly in mrporper
Posted by Chen Miao 3 months, 1 week ago
On 10/31/2025 1:41 AM, Miguel Ojeda wrote:
> On Thu, Oct 30, 2025 at 10:08 AM chenmiao <chenmiao@openatom.club> wrote:
>> -                 rust/libmacros.so rust/libmacros.dylib
>> +                 rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so
> I think we will need the `.dylib` too, given the other one is there
> (for the macOS builds some people do -- Cc'ing Daniel and Tamir). Or
> did you avoid it for some reason?

Hum, in fact I just seen the `.so` so I ignore the `.dylib`. I think should 
add the `.dylib`, I'll make revision later.

Regard,

Chen Miao

>
> Thanks!
>
> Cheers,
> Miguel