power: supply: max77705: Fix two static checker issues

[PATCH 0/2] power: supply: max77705: Fix two static checker issues

Posted by Dan Carpenter 9 months ago

Fix some error handling and an error code bug.

Dan Carpenter (2):
  power: supply: max77705: Fix workqueue error handling in probe
  power: supply: max77705: Fix error code in max77705_get_health()

 drivers/power/supply/max77705_charger.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

-- 
2.47.2

Re: (subset) [PATCH 0/2] power: supply: max77705: Fix two static checker issues

Posted by Sebastian Reichel 7 months, 3 weeks ago

On Fri, 21 Mar 2025 17:34:00 +0300, Dan Carpenter wrote:
> Fix some error handling and an error code bug.
> 
> Dan Carpenter (2):
>   power: supply: max77705: Fix workqueue error handling in probe
>   power: supply: max77705: Fix error code in max77705_get_health()
> 
> drivers/power/supply/max77705_charger.c | 22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> [...]

Applied, thanks!

[1/2] power: supply: max77705: Fix workqueue error handling in probe
      commit: 11741b8e382d34b13277497ab91123d8b0b5c2db

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>

Re: (subset) [PATCH 0/2] power: supply: max77705: Fix two static checker issues

Posted by Sebastian Reichel 7 months, 3 weeks ago

Hi,

On Tue, Apr 29, 2025 at 12:18:43AM +0200, Sebastian Reichel wrote:
> On Fri, 21 Mar 2025 17:34:00 +0300, Dan Carpenter wrote:
> > Fix some error handling and an error code bug.
> > 
> > Dan Carpenter (2):
> >   power: supply: max77705: Fix workqueue error handling in probe
> >   power: supply: max77705: Fix error code in max77705_get_health()
> > 
> > drivers/power/supply/max77705_charger.c | 22 +++++++++++++++-------
> >  1 file changed, 15 insertions(+), 7 deletions(-)
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] power: supply: max77705: Fix workqueue error handling in probe
>       commit: 11741b8e382d34b13277497ab91123d8b0b5c2db

I've queued it, since it improves the driver. But the workqueue also
needs to be released when the module is removed. So I think the
destroy_workqueue() should happen via devm_add_action_or_reset()
instead of what this patch is doing.

Greetings,

-- Sebastian