hwmon: (stts751) Remove an unused field in struct stts751_priv

[PATCH] hwmon: (stts751) Remove an unused field in struct stts751_priv

Posted by Christophe JAILLET 1 year, 7 months ago

In "struct stts751_priv", the 'smbus_timeout' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.

This field was added in the initial commit 7f07ec0fa17a ("hwmon: new driver
for ST stts751 thermal sensor") but was never used.
---
 drivers/hwmon/stts751.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c
index 847c99376930..867410afa4f8 100644
--- a/drivers/hwmon/stts751.c
+++ b/drivers/hwmon/stts751.c
@@ -91,7 +91,6 @@ struct stts751_priv {
 	int event_max, event_min;
 	int therm;
 	int hyst;
-	bool smbus_timeout;
 	int temp;
 	unsigned long last_update, last_alert_update;
 	u8 config;
-- 
2.44.0

Re: [PATCH] hwmon: (stts751) Remove an unused field in struct stts751_priv

Posted by Guenter Roeck 1 year, 7 months ago

On Tue, Apr 30, 2024 at 11:09:07PM +0200, Christophe JAILLET wrote:
> In "struct stts751_priv", the 'smbus_timeout' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied.

Thanks,
Guenter