[PATCH] net: hso: Use GFP_KERNEL instead of GFP_ATOMIC when possible

Christophe JAILLET posted 1 patch 4 years, 4 months ago
drivers/net/usb/hso.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net: hso: Use GFP_KERNEL instead of GFP_ATOMIC when possible
Posted by Christophe JAILLET 4 years, 4 months ago
hso_create_device() is only called from function that already use
GFP_KERNEL. And all the callers are called from the probe function.

So there is no need here to explicitly require a GFP_ATOMIC when
allocating memory.

Use GFP_KERNEL instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/usb/hso.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index f97813a4e8d1..f8221a7acf62 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2319,7 +2319,7 @@ static struct hso_device *hso_create_device(struct usb_interface *intf,
 {
 	struct hso_device *hso_dev;
 
-	hso_dev = kzalloc(sizeof(*hso_dev), GFP_ATOMIC);
+	hso_dev = kzalloc(sizeof(*hso_dev), GFP_KERNEL);
 	if (!hso_dev)
 		return NULL;
 
-- 
2.32.0

Re: [PATCH] net: hso: Use GFP_KERNEL instead of GFP_ATOMIC when possible
Posted by patchwork-bot+netdevbpf@kernel.org 4 years, 4 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Mon, 14 Feb 2022 20:09:06 +0100 you wrote:
> hso_create_device() is only called from function that already use
> GFP_KERNEL. And all the callers are called from the probe function.
> 
> So there is no need here to explicitly require a GFP_ATOMIC when
> allocating memory.
> 
> Use GFP_KERNEL instead.
> 
> [...]

Here is the summary with links:
  - net: hso: Use GFP_KERNEL instead of GFP_ATOMIC when possible
    https://git.kernel.org/netdev/net-next/c/25ce79db8042

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html