[PATCH] task_work: add kerneldoc annotation for 'data' argument

Jens Axboe posted 1 patch 2 years, 5 months ago
[PATCH] task_work: add kerneldoc annotation for 'data' argument
Posted by Jens Axboe 2 years, 5 months ago
A previous commit changed the arguments to task_work_cancel_match(),
but didn't document all of them.

Fixes: c7aab1a7c52b ("task_work: add helper for more targeted task_work canceling")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202309120307.zis3yQGe-lkp@intel.com/
Signed-off-by: Jens Axboe <axboe@kernel.dk>

---

diff --git a/kernel/task_work.c b/kernel/task_work.c
index 065e1ef8fc8d..95a7e1b7f1da 100644
--- a/kernel/task_work.c
+++ b/kernel/task_work.c
@@ -78,6 +78,7 @@ int task_work_add(struct task_struct *task, struct callback_head *work,
  * task_work_cancel_match - cancel a pending work added by task_work_add()
  * @task: the task which should execute the work
  * @match: match function to call
+ * @data: data to be passed in to match function
  *
  * RETURNS:
  * The found work or NULL if not found.

-- 
Jens Axboe
Re: [PATCH] task_work: add kerneldoc annotation for 'data' argument
Posted by Oleg Nesterov 2 years, 5 months ago
On 09/11, Jens Axboe wrote:
>
> --- a/kernel/task_work.c
> +++ b/kernel/task_work.c
> @@ -78,6 +78,7 @@ int task_work_add(struct task_struct *task, struct callback_head *work,
>   * task_work_cancel_match - cancel a pending work added by task_work_add()
>   * @task: the task which should execute the work
>   * @match: match function to call
> + * @data: data to be passed in to match function

Acked-by: Oleg Nesterov <oleg@redhat.com>