[PATCH -next] reset: Remove unused variables

Paul E. McKenney posted 1 patch 2 months, 3 weeks ago
[PATCH -next] reset: Remove unused variables
Posted by Paul E. McKenney 2 months, 3 weeks ago
Neither reset_lookup_mutex nor reset_lookup_list are used anymore, which
results in build errors, so remove them.  It would be best if this were
to be folded into commit 205b261463ff ("reset: remove legacy reset lookup
code"), the better for bisection efforts.

Reproduce on armv8 with:

tools/testing/selftests/rcutorture/bin/torture.sh --duration 10 --do-none --do-rt

Fixes: 205b261463ff ("reset: remove legacy reset lookup code") # -next
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index 22f67fc77ae5..93575d5064a5 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -25,9 +25,6 @@
 static DEFINE_MUTEX(reset_list_mutex);
 static LIST_HEAD(reset_controller_list);
 
-static DEFINE_MUTEX(reset_lookup_mutex);
-static LIST_HEAD(reset_lookup_list);
-
 /* Protects reset_gpio_lookup_list */
 static DEFINE_MUTEX(reset_gpio_lookup_mutex);
 static LIST_HEAD(reset_gpio_lookup_list);
Re: [PATCH -next] reset: Remove unused variables
Posted by Philipp Zabel 2 months, 3 weeks ago
On Mi, 2025-11-12 at 12:59 -0800, Paul E. McKenney wrote:
> Neither reset_lookup_mutex nor reset_lookup_list are used anymore, which
> results in build errors, so remove them.  It would be best if this were
> to be folded into commit 205b261463ff ("reset: remove legacy reset lookup
> code"), the better for bisection efforts.
> 
> Reproduce on armv8 with:
> 
> tools/testing/selftests/rcutorture/bin/torture.sh --duration 10 --do-none --do-rt
> 
> Fixes: 205b261463ff ("reset: remove legacy reset lookup code") # -next
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 22f67fc77ae5..93575d5064a5 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -25,9 +25,6 @@
>  static DEFINE_MUTEX(reset_list_mutex);
>  static LIST_HEAD(reset_controller_list);
>  
> -static DEFINE_MUTEX(reset_lookup_mutex);
> -static LIST_HEAD(reset_lookup_list);
> -
>  /* Protects reset_gpio_lookup_list */
>  static DEFINE_MUTEX(reset_gpio_lookup_mutex);
>  static LIST_HEAD(reset_gpio_lookup_list);

Thank you, just applied to reset/next for now:

[1/1] reset: Remove unused variables
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=3754bc97926e

I'll rebase this branch and squash this fix into 205b261463ff before
sending a pull request. There's also the 25d4d4604d01 / f5c877fb74f4
patch / revert pair that I should drop.

regards
Philipp
Re: [PATCH -next] reset: Remove unused variables
Posted by Paul E. McKenney 2 months, 3 weeks ago
On Thu, Nov 13, 2025 at 10:51:50AM +0100, Philipp Zabel wrote:
> On Mi, 2025-11-12 at 12:59 -0800, Paul E. McKenney wrote:
> > Neither reset_lookup_mutex nor reset_lookup_list are used anymore, which
> > results in build errors, so remove them.  It would be best if this were
> > to be folded into commit 205b261463ff ("reset: remove legacy reset lookup
> > code"), the better for bisection efforts.
> > 
> > Reproduce on armv8 with:
> > 
> > tools/testing/selftests/rcutorture/bin/torture.sh --duration 10 --do-none --do-rt
> > 
> > Fixes: 205b261463ff ("reset: remove legacy reset lookup code") # -next
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > 
> > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > index 22f67fc77ae5..93575d5064a5 100644
> > --- a/drivers/reset/core.c
> > +++ b/drivers/reset/core.c
> > @@ -25,9 +25,6 @@
> >  static DEFINE_MUTEX(reset_list_mutex);
> >  static LIST_HEAD(reset_controller_list);
> >  
> > -static DEFINE_MUTEX(reset_lookup_mutex);
> > -static LIST_HEAD(reset_lookup_list);
> > -
> >  /* Protects reset_gpio_lookup_list */
> >  static DEFINE_MUTEX(reset_gpio_lookup_mutex);
> >  static LIST_HEAD(reset_gpio_lookup_list);
> 
> Thank you, just applied to reset/next for now:
> 
> [1/1] reset: Remove unused variables
>       https://git.pengutronix.de/cgit/pza/linux/commit/?id=3754bc97926e
> 
> I'll rebase this branch and squash this fix into 205b261463ff before
> sending a pull request. There's also the 25d4d4604d01 / f5c877fb74f4
> patch / revert pair that I should drop.

Thank you both!

							Thanx, Paul
Re: [PATCH -next] reset: Remove unused variables
Posted by Bartosz Golaszewski 2 months, 3 weeks ago
On Wed, Nov 12, 2025 at 10:00 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Neither reset_lookup_mutex nor reset_lookup_list are used anymore, which
> results in build errors, so remove them.  It would be best if this were
> to be folded into commit 205b261463ff ("reset: remove legacy reset lookup
> code"), the better for bisection efforts.
>
> Reproduce on armv8 with:
>
> tools/testing/selftests/rcutorture/bin/torture.sh --duration 10 --do-none --do-rt
>
> Fixes: 205b261463ff ("reset: remove legacy reset lookup code") # -next
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 22f67fc77ae5..93575d5064a5 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -25,9 +25,6 @@
>  static DEFINE_MUTEX(reset_list_mutex);
>  static LIST_HEAD(reset_controller_list);
>
> -static DEFINE_MUTEX(reset_lookup_mutex);
> -static LIST_HEAD(reset_lookup_list);
> -
>  /* Protects reset_gpio_lookup_list */
>  static DEFINE_MUTEX(reset_gpio_lookup_mutex);
>  static LIST_HEAD(reset_gpio_lookup_list);
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>