[v1] Add quirk for ADATA SX6000PNP

[PATCH] Add quirk for ADATA SX6000PNP

Posted by Ivan Rubinov 2 years, 7 months ago

 From 5a8f4f54c85ccb8e06b41b27bcaf19ec4f4d7c85 Mon Sep 17 00:00:00 2001
From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
Date: Fri, 10 Feb 2023 14:59:41 +0300
Subject: [PATCH] Add quirk for ADATA SX6000PNP

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
---
  drivers/nvme/host/pci.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c734934c407c..c63443d531b3 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3365,6 +3365,8 @@ static const struct pci_device_id nvme_id_table[] = {
      { PCI_VDEVICE(INTEL, 0x0953),    /* Intel 750/P3500/P3600/P3700 */
          .driver_data = NVME_QUIRK_STRIPE_SIZE |
                  NVME_QUIRK_DEALLOCATE_ZEROES, },
+    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+        .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN | 
NVME_QUIRK_BOGUS_NID, },
      { PCI_VDEVICE(INTEL, 0x0a53),    /* Intel P3520 */
          .driver_data = NVME_QUIRK_STRIPE_SIZE |
                  NVME_QUIRK_DEALLOCATE_ZEROES, },

-- 
2.39.1

Re: [PATCH] Add quirk for ADATA SX6000PNP

Posted by Ivan Rubinov 2 years, 6 months ago

Ivan Rubinov писал(а) 2023-02-10 15:10:
> From 5a8f4f54c85ccb8e06b41b27bcaf19ec4f4d7c85 Mon Sep 17 00:00:00 2001
> From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> Date: Fri, 10 Feb 2023 14:59:41 +0300
> Subject: [PATCH] Add quirk for ADATA SX6000PNP
> 
> Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> ---
>  drivers/nvme/host/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index c734934c407c..c63443d531b3 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3365,6 +3365,8 @@ static const struct pci_device_id nvme_id_table[] = {
>      { PCI_VDEVICE(INTEL, 0x0953),    /* Intel 750/P3500/P3600/P3700 */
>          .driver_data = NVME_QUIRK_STRIPE_SIZE |
>                  NVME_QUIRK_DEALLOCATE_ZEROES, },
> +    { PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
> +        .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN | NVME_QUIRK_BOGUS_NID, },
>      { PCI_VDEVICE(INTEL, 0x0a53),    /* Intel P3520 */
>          .driver_data = NVME_QUIRK_STRIPE_SIZE |
>                  NVME_QUIRK_DEALLOCATE_ZEROES, },
I am sorry guys its doesnt work. I send new file which work

Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d839689..3f4da40 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3480,6 +3480,9 @@ static const struct pci_device_id nvme_id_table[]
= {
 	{ PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x10ec, 0x5763),   /* ADATA SX6000PNP */
+                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+                                NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },

Re: [PATCH] Add quirk for ADATA SX6000PNP

Posted by Daniel Wagner 2 years, 6 months ago

On Fri, Feb 17, 2023 at 01:28:42PM +0000, Ivan Rubinov wrote:
> Ivan Rubinov писал(а) 2023-02-10 15:10:
> > From 5a8f4f54c85ccb8e06b41b27bcaf19ec4f4d7c85 Mon Sep 17 00:00:00 2001
> > From: Ivan Rubinov <linuxkernelpatch8234@riseup.net>
> > Date: Fri, 10 Feb 2023 14:59:41 +0300
> > Subject: [PATCH] Add quirk for ADATA SX6000PNP
> > 
> > Signed-off-by: Ivan Rubinov <linuxkernelpatch8234@riseup.net>

Can you post the output of 'nvme id-ctrl' for your two devices?
Because the ones in

  https://bugzilla.opensuse.org/show_bug.cgi?id=1207827

clearly have clearly different subnqn.

Although, I have to admint they look suspicious but they are not the same:

subnqn    : nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2K2129Q696LA
subnqn    : nqn.2018-05.com.example:nvme:nvm-subsystem-OUI00E04C2J4120007707

Re: [PATCH] Add quirk for ADATA SX6000PNP

Posted by Christoph Hellwig 2 years, 7 months ago

I've already applied a patch from Daniel Wagner for this device,
but thanks for sending it in!

Re: [PATCH] Add quirk for ADATA SX6000PNP

Posted by Daniel Wagner 2 years, 7 months ago

On Mon, Feb 13, 2023 at 07:08:50AM +0100, Christoph Hellwig wrote:
> I've already applied a patch from Daniel Wagner for this device,
> but thanks for sending it in!

This patch also add NVME_QUIRK_IGNORE_DEV_SUBNQN. Is it necessary?