kmod: configure.ac: In _Noreturn check, include <stdlib.h> for exit

[PATCH] kmod: configure.ac: In _Noreturn check, include <stdlib.h> for exit

Posted by Florian Weimer 2 years, 9 months ago

Otherwise, an implicit functiona declaration is used, causing
a C99 compatibility issue.

Signed-off-by: Florian Weimer <fweimer@redhat.com>

---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6989e93..12e0518 100644
--- a/configure.ac
+++ b/configure.ac
@@ -68,7 +68,8 @@ AC_COMPILE_IFELSE(
 
 AC_MSG_CHECKING([whether _Noreturn is supported])
 AC_COMPILE_IFELSE(
-	[AC_LANG_SOURCE([[_Noreturn int foo(void) { exit(0); }]])],
+	[AC_LANG_SOURCE([[#include <stdlib.h>
+	_Noreturn int foo(void) { exit(0); }]])],
         [AC_DEFINE([HAVE_NORETURN], [1], [Define if _Noreturn is available])
 	 AC_MSG_RESULT([yes])],
 	[AC_MSG_RESULT([no])])

base-commit: 6c5f2f13689e6a4668f87171752d7818bed4b602

Re: [PATCH] kmod: configure.ac: In _Noreturn check, include <stdlib.h> for exit

Posted by Lucas De Marchi 2 years, 8 months ago

On Sat, Dec 17, 2022 at 05:52:34PM +0100, Florian Weimer wrote:
>Otherwise, an implicit functiona declaration is used, causing
>a C99 compatibility issue.
>
>Signed-off-by: Florian Weimer <fweimer@redhat.com>

applied, thanks

Lucas De Marchi

>
>---
> configure.ac | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/configure.ac b/configure.ac
>index 6989e93..12e0518 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -68,7 +68,8 @@ AC_COMPILE_IFELSE(
>
> AC_MSG_CHECKING([whether _Noreturn is supported])
> AC_COMPILE_IFELSE(
>-	[AC_LANG_SOURCE([[_Noreturn int foo(void) { exit(0); }]])],
>+	[AC_LANG_SOURCE([[#include <stdlib.h>
>+	_Noreturn int foo(void) { exit(0); }]])],
>         [AC_DEFINE([HAVE_NORETURN], [1], [Define if _Noreturn is available])
> 	 AC_MSG_RESULT([yes])],
> 	[AC_MSG_RESULT([no])])
>
>base-commit: 6c5f2f13689e6a4668f87171752d7818bed4b602
>